Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2320413002: [Cronet] Add presubmit check to verify Cronet package division. (Closed)

Created:
4 years, 3 months ago by pauljensen
Modified:
4 years, 3 months ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Add presubmit check to verify Cronet package division. Cronet API classes must be in org.chromium.net package and Cronet implementation classes must not be in org.chromium.net package. BUG=629299 Committed: https://crrev.com/17ebec651e9b55a0dfe8d64864a0bc3592b3b4ee Cr-Commit-Position: refs/heads/master@{#418623}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Patch Set 5 : check for imports #

Patch Set 6 : don't check for imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M components/cronet/PRESUBMIT.py View 1 2 3 5 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
pauljensen
4 years, 3 months ago (2016-09-09 11:08:13 UTC) #1
pauljensen
4 years, 3 months ago (2016-09-09 11:22:05 UTC) #2
pauljensen
4 years, 3 months ago (2016-09-09 11:25:04 UTC) #3
pauljensen
Andrei, PTAL.
4 years, 3 months ago (2016-09-09 11:28:55 UTC) #7
kapishnikov
On 2016/09/09 11:28:55, pauljensen wrote: > Andrei, PTAL. Looks good. One thing, while refactoring I ...
4 years, 3 months ago (2016-09-09 14:42:02 UTC) #8
pauljensen
On 2016/09/09 14:42:02, kapishnikov wrote: > On 2016/09/09 11:28:55, pauljensen wrote: > > Andrei, PTAL. ...
4 years, 3 months ago (2016-09-09 18:58:58 UTC) #9
pauljensen
Ping Andrei.
4 years, 3 months ago (2016-09-14 11:58:38 UTC) #10
kapishnikov
Paul, sorry for the late review. LGTM
4 years, 3 months ago (2016-09-14 17:18:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320413002/100001
4 years, 3 months ago (2016-09-14 18:02:11 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-09-14 18:53:45 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 18:56:03 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/17ebec651e9b55a0dfe8d64864a0bc3592b3b4ee
Cr-Commit-Position: refs/heads/master@{#418623}

Powered by Google App Engine
This is Rietveld 408576698