Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ios/chrome/browser/reading_list/url_downloader_unittest.cc

Issue 2320403002: Update reading list entry on download (Closed)
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/reading_list/url_downloader_unittest.cc
diff --git a/ios/chrome/browser/reading_list/url_downloader_unittest.cc b/ios/chrome/browser/reading_list/url_downloader_unittest.cc
index 14ee119ac500fb8b0f5f734bb13e49848576cdfd..8ba654b4dfe21f7e086a27e19e10c51ab37a54cb 100644
--- a/ios/chrome/browser/reading_list/url_downloader_unittest.cc
+++ b/ios/chrome/browser/reading_list/url_downloader_unittest.cc
@@ -25,7 +25,7 @@ class DistillerViewerTest : public dom_distiller::DistillerViewerInterface {
const DistillationFinishedCallback& callback)
: dom_distiller::DistillerViewerInterface(nil, nil) {
std::vector<ImageInfo> images;
- callback.Run(url, "html", images);
+ callback.Run(url, "html", images, "title");
}
void OnArticleReady(
@@ -73,7 +73,7 @@ class MockURLDownloader : public URLDownloader {
private:
void DownloadURL(GURL url, bool offlineURLExists) override {
if (offlineURLExists) {
- DownloadCompletionHandler(url, false);
+ DownloadCompletionHandler(url, std::string(), DOWNLOAD_EXISTS);
return;
}
distiller_.reset(new DistillerViewerTest(
@@ -81,7 +81,10 @@ class MockURLDownloader : public URLDownloader {
base::Bind(&URLDownloader::DistillerCallback, base::Unretained(this))));
}
- void OnEndDownload(const GURL& url, bool success) {
+ void OnEndDownload(const GURL& url,
+ SuccessState success,
+ const GURL& distilledURL,
+ const std::string& title) {
downloaded_files_.push_back(url);
}

Powered by Google App Engine
This is Rietveld 408576698