Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: ios/chrome/browser/dom_distiller/distiller_viewer.h

Issue 2320403002: Update reading list entry on download (Closed)
Patch Set: address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/dom_distiller/distiller_viewer.h
diff --git a/ios/chrome/browser/dom_distiller/distiller_viewer.h b/ios/chrome/browser/dom_distiller/distiller_viewer.h
index 4442493c6ac0f53af834830c21151ca5a9dbe65a..639b7ea66770ba92dff110b5d4194d5df7a4880b 100644
--- a/ios/chrome/browser/dom_distiller/distiller_viewer.h
+++ b/ios/chrome/browser/dom_distiller/distiller_viewer.h
@@ -23,15 +23,16 @@ class DistilledPagePrefs;
// contains.
class DistillerViewerInterface : public DomDistillerRequestViewBase {
public:
- typedef struct {
+ struct ImageInfo {
// The url of the image.
GURL url;
// The image data as a string.
std::string data;
- } ImageInfo;
- typedef base::Callback<void(const GURL&,
- const std::string&,
- const std::vector<ImageInfo>& images)>
+ };
+ typedef base::Callback<void(const GURL& url,
+ const std::string& html,
+ const std::vector<ImageInfo>& images,
+ const std::string& title)>
gambard 2016/09/15 13:14:11 This breaks reader_mode_controller.mm
DistillationFinishedCallback;
DistillerViewerInterface(dom_distiller::DomDistillerService* distillerService,

Powered by Google App Engine
This is Rietveld 408576698