Update reading list entry on download

ios/chrome/browser/dom_distiller/distiller_viewer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/dom_distiller/distiller_viewer.h"
 
 #include <string>
 #include <utility>
 
 #include "components/dom_distiller/core/distilled_page_prefs.h"
@@ skipping 21 matching lines @@
       this, distillerService->CreateDefaultDistillerPage(gfx::Size()), url);
 
   TakeViewerHandle(std::move(viewer_handle));
 }
 
 DistillerViewer::~DistillerViewer() {}
 
 void DistillerViewer::OnArticleReady(
     const dom_distiller::DistilledArticleProto* article_proto) {
   DomDistillerRequestViewBase::OnArticleReady(article_proto);
+  if (article_proto->pages_size() > 0) {
+    std::vector<ImageInfo> images;
+    for (int i = 0; i < article_proto->pages(0).image_size(); i++) {
+      auto image = article_proto->pages(0).image(i);
+      images.push_back({GURL(image.url()), image.data()});

[sdefresne, 2016/09/09 09:58:57]

I think this should be:

images.push_back(ImageInfo(GURL(image.url()), image.data()));

or:

images.emplace_back(GURL(image.url()), image.data());

+    }
 
-  std::vector<ImageInfo> images;
-  for (int i = 0; i < article_proto->pages(0).image_size(); i++) {
-    auto image = article_proto->pages(0).image(i);
-    images.push_back({GURL(image.url()), image.data()});
+    const std::string html = viewer::GetUnsafeArticleTemplateHtml(
+        url_.spec(), distilled_page_prefs_->GetTheme(),
+        distilled_page_prefs_->GetFontFamily());
+
+    std::string html_and_script(html);
+    html_and_script +=
+        "<script> distiller_on_ios = true; " + js_buffer_ + "</script>";
+    callback_.Run(url_, html_and_script, images, article_proto->title());
+  } else {
+    callback_.Run(url_, "", {}, "");

[sdefresne, 2016/09/09 09:58:57]

Please prefer std::string() to "".

[lody, 2016/09/09 12:17:53]

Done.

   }
-
-  const std::string html = viewer::GetUnsafeArticleTemplateHtml(
-      url_.spec(), distilled_page_prefs_->GetTheme(),
-      distilled_page_prefs_->GetFontFamily());
-
-  std::string html_and_script(html);
-  html_and_script +=
-      "<script> distiller_on_ios = true; " + js_buffer_ + "</script>";
-  callback_.Run(url_, html_and_script, images);
 }
 
 void DistillerViewer::SendJavaScript(const std::string& buffer) {
   js_buffer_ += buffer;
 }
 
 }  // namespace dom_distiller