Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2320393002: Let LayoutNG handle childless block flows. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let LayoutNG handle childless block flows. The fact that they are marked with childrenInline() doesn't matter if they have no children. BUG=635619 Committed: https://crrev.com/3a8d44bde377af4848928cac6fa3cae84a313ead Cr-Commit-Position: refs/heads/master@{#417543}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_box.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
Just playing a little with LayoutNG. I found it unnecessary that leaf blocks had to ...
4 years, 3 months ago (2016-09-09 07:41:06 UTC) #2
eae
LGTM!
4 years, 3 months ago (2016-09-09 08:15:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320393002/1
4 years, 3 months ago (2016-09-09 08:15:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 09:39:58 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 09:41:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a8d44bde377af4848928cac6fa3cae84a313ead
Cr-Commit-Position: refs/heads/master@{#417543}

Powered by Google App Engine
This is Rietveld 408576698