Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 2320323002: Revert of cheets: implement cros side of WallpaperManagerService. (Closed)

Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, oshima+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, davemoore+watch_chromium.org, qsr+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cheets: implement cros side of WallpaperManagerService. (patchset #16 id:300001 of https://codereview.chromium.org/2264743002/ ) Reason for revert: Broke the build. Not sure how this made it past the CQ: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/45818 Original issue's description: > cheets: implement cros side of WallpaperManagerService. > > Rename ArcWallpaperHandler to ArcWallpaperService and implement it as an ArcService, which handles WallpaperManager API from Android. > > Test=Manually open PickMyWallpaper app and set wallpaper > Test=run cts android.content.cts.ContextWrapperTest > > Bug=642465 > > Committed: https://crrev.com/533be7ef1063d285008913c9784d8d852055c8bd > Cr-Commit-Position: refs/heads/master@{#417428} TBR=xiaohuic@chromium.org,xiyuan@chromium.org,nya@chromium.org,lhchavez@chromium.org,hidehiko@chromium.org,dcheng@chromium.org,yusukes@chromium.org,muyuanli@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Bug=642465 Committed: https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf Cr-Commit-Position: refs/heads/master@{#417431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -267 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_service_launcher.cc View 3 chunks +2 lines, -3 lines 0 comments Download
A chrome/browser/chromeos/arc/arc_wallpaper_handler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/arc/arc_wallpaper_handler.cc View 1 chunk +89 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/arc/arc_wallpaper_service.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/chromeos/arc/arc_wallpaper_service.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M components/arc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/arc/arc_bridge_host_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/arc/arc_bridge_host_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/arc/arc_bridge_service.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 2 chunks +2 lines, -6 lines 0 comments Download
D components/arc/common/wallpaper.mojom View 1 chunk +0 lines, -25 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M components/arc/set_wallpaper_delegate.h View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Russell (switch to Gerrit)
Created Revert of cheets: implement cros side of WallpaperManagerService.
4 years, 3 months ago (2016-09-08 23:27:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320323002/1
4 years, 3 months ago (2016-09-08 23:27:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 23:28:37 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 23:30:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9aea000394714d2fbb20850021f6204f2256b9cf
Cr-Commit-Position: refs/heads/master@{#417431}

Powered by Google App Engine
This is Rietveld 408576698