Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: components/network_session_configurator/network_session_configurator.cc

Issue 2320313003: Revert of Remove obsolete QUIC disabling code. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator.cc
diff --git a/components/network_session_configurator/network_session_configurator.cc b/components/network_session_configurator/network_session_configurator.cc
index 593da58040cf3857f2a3b10b80469890dbee58d3..e8d894a4358c11da1523dc3bdfca96c9ed301d99 100644
--- a/components/network_session_configurator/network_session_configurator.cc
+++ b/components/network_session_configurator/network_session_configurator.cc
@@ -152,6 +152,27 @@
GetVariationParam(quic_trial_params, "force_hol_blocking"), "true");
}
+int GetQuicMaxNumberOfLossyConnections(
+ const VariationParameters& quic_trial_params) {
+ int value;
+ if (base::StringToInt(GetVariationParam(quic_trial_params,
+ "max_number_of_lossy_connections"),
+ &value)) {
+ return value;
+ }
+ return 0;
+}
+
+float GetQuicPacketLossThreshold(const VariationParameters& quic_trial_params) {
+ double value;
+ if (base::StringToDouble(
+ GetVariationParam(quic_trial_params, "packet_loss_threshold"),
+ &value)) {
+ return static_cast<float>(value);
+ }
+ return 0.0f;
+}
+
int GetQuicSocketReceiveBufferSize(
const VariationParameters& quic_trial_params) {
int value;
@@ -316,6 +337,15 @@
ShouldQuicDisableDiskCache(quic_trial_params);
params->quic_prefer_aes = ShouldQuicPreferAes(quic_trial_params);
params->quic_force_hol_blocking = ShouldForceHolBlocking(quic_trial_params);
+ int max_number_of_lossy_connections =
+ GetQuicMaxNumberOfLossyConnections(quic_trial_params);
+ if (max_number_of_lossy_connections != 0) {
+ params->quic_max_number_of_lossy_connections =
+ max_number_of_lossy_connections;
+ }
+ float packet_loss_threshold = GetQuicPacketLossThreshold(quic_trial_params);
+ if (packet_loss_threshold != 0)
+ params->quic_packet_loss_threshold = packet_loss_threshold;
// Default to disabling port selection on all channels.
params->enable_quic_port_selection = false;
params->quic_connection_options =

Powered by Google App Engine
This is Rietveld 408576698