Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2320313002: Upstream the code that uses the new addCompletedDownload() API (Closed)

Created:
4 years, 3 months ago by qinmin
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream the code that uses the new addCompletedDownload() API The new API is public and we will use this API for Android N and above. Downstream CL:https://chrome-internal-review.googlesource.com/285475 Committed: https://crrev.com/c047f67f9c8160c7951bb75de6639616b96cb58e Cr-Commit-Position: refs/heads/master@{#417648}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java View 2 chunks +28 lines, -0 lines 2 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
qinmin
PTAL
4 years, 3 months ago (2016-09-08 22:32:19 UTC) #2
gone
https://codereview.chromium.org/2320313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java (right): https://codereview.chromium.org/2320313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java#newcode40 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java:40: if (Build.VERSION.SDK_INT > Build.VERSION_CODES.M) { If this is now ...
4 years, 3 months ago (2016-09-09 00:44:00 UTC) #3
qinmin
https://codereview.chromium.org/2320313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java (right): https://codereview.chromium.org/2320313002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java#newcode40 chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java:40: if (Build.VERSION.SDK_INT > Build.VERSION_CODES.M) { On 2016/09/09 00:43:59, dfalcantara ...
4 years, 3 months ago (2016-09-09 17:36:22 UTC) #4
gone
lgtm
4 years, 3 months ago (2016-09-09 17:37:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320313002/1
4 years, 3 months ago (2016-09-09 18:00:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 18:40:34 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 18:41:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c047f67f9c8160c7951bb75de6639616b96cb58e
Cr-Commit-Position: refs/heads/master@{#417648}

Powered by Google App Engine
This is Rietveld 408576698