third_party/WebKit/Source/core/page/Page.cpp - Issue 2320303002: Reset VisualViewport position after same page navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2320303002: Reset VisualViewport position after same page navigation (Closed)

Patch Set: move reset to Page::didCommitLoad and create test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index fe3e99ea8e0f9a28f94f496c9aba209c8ad98917..68ccfa051055257f0717b1d4ec10990256d44c72 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -436,6 +436,7 @@ void Page::didCommitLoad(LocalFrame* frame)

useCounter().didCommitLoad();

deprecation().clearSuppression();

frameHost().visualViewport().sendUMAMetrics();

+ frameHost().visualViewport().setScrollPosition(DoublePoint(), ProgrammaticScroll);

bokan 2016/09/12 18:55:23 Please add a comment that we need to reset the scr

m_hostsUsingFeatures.updateMeasurementsAndClear();

UserGestureIndicator::clearProcessedUserGestureSinceLoad();

}