Reset VisualViewport position after same page navigation

third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/VisualViewport.h"
 
 #include "core/dom/Document.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 177 matching lines @@
     : public testing::WithParamInterface<TestParamRootLayerScrolling>
     , private ScopedRootLayerScrollingForTest
     , public VisualViewportTest {
 public:
     ParameterizedVisualViewportTest()
         : ScopedRootLayerScrollingForTest(GetParam()) { }
 };
 
 INSTANTIATE_TEST_CASE_P(All, ParameterizedVisualViewportTest, ::testing::Bool());
 
+static WebGestureEvent fatTap(int x, int y)
+{
+    WebGestureEvent event;
+    event.type = WebInputEvent::GestureTap;
+    event.sourceDevice = WebGestureDeviceTouchscreen;
+    event.x = x;
+    event.y = y;
+    event.data.tap.width = 50;
+    event.data.tap.height = 50;
+    return event;
+}
+
 // Test that resizing the VisualViewport works as expected and that resizing the
 // WebView resizes the VisualViewport.
 TEST_P(ParameterizedVisualViewportTest, TestResize)
 {
     initializeWithDesktopSettings();
     webViewImpl()->resize(IntSize(320, 240));
 
     navigateTo("about:blank");
     forceFullCompositingUpdate();
 
@@ skipping 1709 matching lines @@
     webViewImpl()->resize(IntSize(600, 800));
 
     EXPECT_POINT_EQ(
         DoublePoint(),
         frameView.layoutViewportScrollableArea()->scrollPositionDouble());
     EXPECT_EQ(600, scroller->scrollTop());
 
     RuntimeEnabledFeatures::setSetRootScrollerEnabled(wasRootScrollerEnabled);
 }
 
+// Ensure that the scroll position is correct when we navigate to same page after scale(zoom-in/zoom-out)
+// crbug.com/642279
+TEST_P(ParameterizedVisualViewportTest, ScrollPositionForLinkToSamePageAfterResize)
+{
+    initializeWithAndroidSettings();
+
+    registerMockedHttpURLLoad("same-page-navigate.html");
+    navigateTo(m_baseURL + "same-page-navigate.html");
+
+    webViewImpl()->setPageScaleFactor(2.0);
+
+    Element* link = frame()->document()->getElementById("same-page");
+    webViewImpl()->handleInputEvent(fatTap(link->offsetLeft(), link->offsetTop()));
+    FrameTestHelpers::pumpPendingRequestsForFrameToLoad(webViewImpl()->mainFrameImpl());
+
+    FrameView& frameView = *webViewImpl()->mainFrameImpl()->frameView();
+    EXPECT_POINT_EQ(
+        DoublePoint(),
+        frameView.layoutViewportScrollableArea()->scrollPositionDouble());

[bokan, 2016/09/13 14:56:47]

The bug is that the *visual viewport* isn't reset. This check should be against
the visual viewport. Also, please run this test without your fix above and make
sure it fails (i.e. having this test would have caught the bug).

+}
+
+
+
 } // namespace