Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2320303002: Reset VisualViewport position after same page navigation (Closed)
Patch Set: change test to async Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All R ights Reserved.
3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 429
430 void Page::didCommitLoad(LocalFrame* frame) 430 void Page::didCommitLoad(LocalFrame* frame)
431 { 431 {
432 if (m_mainFrame == frame) { 432 if (m_mainFrame == frame) {
433 // TODO(rbyers): Most of this doesn't appear to take into account that e ach 433 // TODO(rbyers): Most of this doesn't appear to take into account that e ach
434 // SVGImage gets it's own Page instance. 434 // SVGImage gets it's own Page instance.
435 frameHost().consoleMessageStorage().clear(); 435 frameHost().consoleMessageStorage().clear();
436 useCounter().didCommitLoad(); 436 useCounter().didCommitLoad();
437 deprecation().clearSuppression(); 437 deprecation().clearSuppression();
438 frameHost().visualViewport().sendUMAMetrics(); 438 frameHost().visualViewport().sendUMAMetrics();
439 // Need reset visual viewport position, fix for crbug.com/642279
bokan 2016/09/15 15:03:47 Please fix the comment. See my comment on this lin
440 frameHost().visualViewport().setScrollPosition(DoublePoint(), Programmat icScroll);
439 m_hostsUsingFeatures.updateMeasurementsAndClear(); 441 m_hostsUsingFeatures.updateMeasurementsAndClear();
440 UserGestureIndicator::clearProcessedUserGestureSinceLoad(); 442 UserGestureIndicator::clearProcessedUserGestureSinceLoad();
441 } 443 }
442 } 444 }
443 445
444 void Page::acceptLanguagesChanged() 446 void Page::acceptLanguagesChanged()
445 { 447 {
446 HeapVector<Member<LocalFrame>> frames; 448 HeapVector<Member<LocalFrame>> frames;
447 449
448 // Even though we don't fire an event from here, the LocalDOMWindow's will f ire 450 // Even though we don't fire an event from here, the LocalDOMWindow's will f ire
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 { 522 {
521 } 523 }
522 524
523 Page::PageClients::~PageClients() 525 Page::PageClients::~PageClients()
524 { 526 {
525 } 527 }
526 528
527 template class CORE_TEMPLATE_EXPORT Supplement<Page>; 529 template class CORE_TEMPLATE_EXPORT Supplement<Page>;
528 530
529 } // namespace blink 531 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698