Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 23203002: Make HConstant::InstanceOf less ambiguous. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger
Modified:
7 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Make HConstant::InstanceOf less ambiguous. R=verwaest@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16279

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Toon Verwaest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/hydrogen-instructions.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
7 years, 4 months ago (2013-08-14 17:21:04 UTC) #1
Toon Verwaest
Lgtm with a comment for future reference. https://codereview.chromium.org/23203002/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/23203002/diff/1/src/hydrogen-instructions.cc#newcode2869 src/hydrogen-instructions.cc:2869: map->CanTransition() && ...
7 years, 4 months ago (2013-08-14 17:48:24 UTC) #2
Michael Starzinger
PTAL. https://codereview.chromium.org/23203002/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/23203002/diff/1/src/hydrogen-instructions.cc#newcode2869 src/hydrogen-instructions.cc:2869: map->CanTransition() && On 2013/08/14 17:48:24, Toon Verwaest wrote: ...
7 years, 4 months ago (2013-08-16 08:22:50 UTC) #3
Toon Verwaest
lgtm
7 years, 4 months ago (2013-08-16 15:42:01 UTC) #4
Michael Starzinger
7 years, 4 months ago (2013-08-22 14:23:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r16279.

Powered by Google App Engine
This is Rietveld 408576698