Refactors DimWindow and moves to ash/common

ash/aura/wm_window_aura.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/aura/wm_window_aura.h"
 
 #include "ash/aura/aura_layout_manager_adapter.h"
 #include "ash/aura/wm_root_window_controller_aura.h"
 #include "ash/aura/wm_shell_aura.h"
 #include "ash/common/ash_constants.h"
@@ skipping 117 matching lines @@
     result[i] = WmWindowAura::GetAuraWindow(windows[i]);
   return result;
 }
 
 // static
 const aura::Window* WmWindowAura::GetAuraWindow(const WmWindow* wm_window) {
   return wm_window ? static_cast<const WmWindowAura*>(wm_window)->aura_window()
                    : nullptr;
 }
 
+void WmWindowAura::Destroy() {
+  delete window_;
+}

[James Cook, 2016/09/09 21:33:36]

set window_ = nullptr here?

[sky, 2016/09/09 21:50:45]

'this' should be deleted as a result of delete window_. I'll add a comment.

+
 const WmWindow* WmWindowAura::GetRootWindow() const {
   return Get(window_->GetRootWindow());
 }
 
 WmRootWindowController* WmWindowAura::GetRootWindowController() {
   aura::Window* root = window_->GetRootWindow();
   return root ? WmRootWindowControllerAura::Get(root) : nullptr;
 }
 
 WmShell* WmWindowAura::GetShell() const {
@@ skipping 210 matching lines @@
       layout_manager ? new AuraLayoutManagerAdapter(std::move(layout_manager))
                      : nullptr);
 }
 
 WmLayoutManager* WmWindowAura::GetLayoutManager() {
   AuraLayoutManagerAdapter* adapter =
       static_cast<AuraLayoutManagerAdapter*>(window_->layout_manager());
   return adapter ? adapter->wm_layout_manager() : nullptr;
 }
 
+void WmWindowAura::SetVisibilityChangesAnimated() {
+  ::wm::SetWindowVisibilityChangesAnimated(window_);
+}
+
 void WmWindowAura::SetVisibilityAnimationType(int type) {
   ::wm::SetWindowVisibilityAnimationType(window_, type);
 }
 
 void WmWindowAura::SetVisibilityAnimationDuration(base::TimeDelta delta) {
   ::wm::SetWindowVisibilityAnimationDuration(window_, delta);
 }
 
 void WmWindowAura::SetVisibilityAnimationTransition(
     ::wm::WindowVisibilityAnimationTransition transition) {
@@ skipping 446 matching lines @@
                     OnTransientChildAdded(this, Get(transient)));
 }
 
 void WmWindowAura::OnTransientChildRemoved(aura::Window* window,
                                            aura::Window* transient) {
   FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_,
                     OnTransientChildRemoved(this, Get(transient)));
 }
 
 }  // namespace ash