Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2320253002: Fix CPDFSDK_PageView cleanup. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez, Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix CPDFSDK_PageView cleanup. In https://pdfium.googlesource.com/pdfium/+/461eeafe191068ac8c32f2717907fc6a22a667d2 we moved the map cleanup for the page view to happen before the page view was destroyed and before we killed the annotation focus. The map removal must happen before the pageview is destroyed, but must happen after we've killed the annotation focus in order to not create duplicate page views which point to the same page. BUG=chromium:645122 Committed: https://pdfium.googlesource.com/pdfium/+/c2d0e29cd8fa24c9af0cc4f2a15f90096a5ca8e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
dsinclair
PTAL. The ownership between the page view's and the pages is .... hard.
4 years, 3 months ago (2016-09-08 20:14:03 UTC) #4
Tom Sepez
Good luck. LGTM.
4 years, 3 months ago (2016-09-08 20:15:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320253002/1
4 years, 3 months ago (2016-09-08 20:22:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/1994) mac_no_v8 on master.tryserver.client.pdfium (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 20:25:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320253002/1
4 years, 3 months ago (2016-09-08 20:41:37 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 21:03:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c2d0e29cd8fa24c9af0cc4f2a15f90096a5c...

Powered by Google App Engine
This is Rietveld 408576698