Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2320213004: Port IndexedDB open() and database callbacks to Mojo. (Closed)

Created:
4 years, 3 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, cmumford, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, dglazkov+blink, jam, jsbell+idb_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port IndexedDB open() and database callbacks to Mojo. This is the first of many changes that will migrate IndexedDB from Chrome IPC to Mojo. We start with implementing DatabaseFactory::Open() and the associated DatabaseClient interface used for sending database events. BUG=627484

Patch Set 1 #

Patch Set 2 : Make DatabaseClient an associated interface. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+514 lines, -744 lines) Patch
M content/browser/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/indexed_db/database_factory_impl.h View 1 1 chunk +56 lines, -0 lines 0 comments Download
A content/browser/indexed_db/database_factory_impl.cc View 1 1 chunk +134 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.h View 3 chunks +1 line, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 19 chunks +0 lines, -22 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cursor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.h View 1 3 chunks +8 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database_callbacks.cc View 1 4 chunks +71 lines, -26 lines 0 comments Download
D content/browser/indexed_db/indexed_db_database_error.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/browser/indexed_db/indexed_db_database_error.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/indexed_db/mock_indexed_db_database_callbacks.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 1 6 chunks +10 lines, -27 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.cc View 1 13 chunks +20 lines, -93 lines 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.h View 4 chunks +0 lines, -4 lines 0 comments Download
M content/child/indexed_db/webidbdatabase_impl.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M content/child/indexed_db/webidbfactory_impl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/child/indexed_db/webidbfactory_impl.cc View 1 2 chunks +11 lines, -10 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A content/common/indexed_db/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/indexed_db/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A + content/common/indexed_db/indexed_db_database_error.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/common/indexed_db/indexed_db_database_error.cc View 1 chunk +3 lines, -1 line 0 comments Download
A content/common/indexed_db/indexed_db_database_error_struct_traits.h View 1 chunk +37 lines, -0 lines 0 comments Download
A content/common/indexed_db/indexed_db_error_info.typemap View 1 chunk +10 lines, -0 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 4 chunks +1 line, -26 lines 0 comments Download
A + content/common/indexed_db/typemaps.gni View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/chromium_bindings_configuration.gni View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/BUILD.gn View 1 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h View 1 5 chunks +16 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 1 7 chunks +17 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.h View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/modules/indexeddb/IDBDatabaseCallbacks.cpp View 1 chunk +0 lines, -82 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp View 1 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp View 1 6 chunks +19 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp View 4 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp View 4 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.h View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/indexeddb/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabase.h View 2 chunks +1 line, -2 lines 0 comments Download
D third_party/WebKit/public/platform/modules/indexeddb/WebIDBDatabaseCallbacks.h View 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/WebKit/public/platform/modules/indexeddb/WebIDBFactory.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/public/platform/modules/indexeddb/indexed_db.mojom View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Reilly Grant (use Gerrit)
cmumford@, please review the change in general. dcheng@, please review indexed_db.mojom and indexed_db_database_error_struct_traits.h.
4 years, 3 months ago (2016-09-09 23:34:01 UTC) #4
Reilly Grant (use Gerrit)
rockot@, can you also take a general look to let me know if I'm using ...
4 years, 3 months ago (2016-09-10 01:28:12 UTC) #11
haraken
This CL looks amazing! Changes to WebKit/ generally look good.
4 years, 3 months ago (2016-09-12 01:01:49 UTC) #14
Ken Rockot(use gerrit already)
You appear to be using associated interfaces correctly. My only concern, since I don't really ...
4 years, 3 months ago (2016-09-12 20:52:37 UTC) #15
Reilly Grant (use Gerrit)
4 years, 2 months ago (2016-10-04 02:01:16 UTC) #16
Abandoning this CL as it changes too much too quickly and won't work from worker
threads. https://codereview.chromium.org/2370643004 is its replacement.

Powered by Google App Engine
This is Rietveld 408576698