Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: src/globals.h

Issue 23202017: Further cleanup of test for V8_INFINITY. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Improve test for GCC. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 12 matching lines...) Expand all
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #ifndef V8_GLOBALS_H_ 28 #ifndef V8_GLOBALS_H_
29 #define V8_GLOBALS_H_ 29 #define V8_GLOBALS_H_
30 30
31 #include "../include/v8stdint.h" 31 #include "../include/v8stdint.h"
32 32
33 // Find a working V8_INFINITY.
34 #if V8_CC_GNU
35 // Unfortunately, the INFINITY macro cannot be used with the '-pedantic' 33 // Unfortunately, the INFINITY macro cannot be used with the '-pedantic'
36 // warning flag and certain versions of GCC due to a bug: 34 // warning flag and certain versions of GCC due to a bug:
37 // http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11931 35 // http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11931
38 // For now, we use the more involved template-based version from <limits>, but 36 // For now, we use the more involved template-based version from <limits>, but
39 // only when compiling with GCC versions affected by the bug (2.96.x - 4.0.x) 37 // only when compiling with GCC versions affected by the bug (2.96.x - 4.0.x)
40 # if V8_GNUC_PREREQ(2, 96, 0) && !V8_GNUC_PREREQ(4, 1, 0) 38 #if V8_CC_GNU && V8_GNUC_PREREQ(2, 96, 0) && !V8_GNUC_PREREQ(4, 1, 0)
41 # include <limits> // NOLINT 39 # include <limits> // NOLINT
42 # define V8_INFINITY std::numeric_limits<double>::infinity() 40 # define V8_INFINITY std::numeric_limits<double>::infinity()
43 # else
44 # define V8_INFINITY INFINITY
45 # endif
46 #elif V8_CC_MSVC 41 #elif V8_CC_MSVC
47 # define V8_INFINITY HUGE_VAL 42 # define V8_INFINITY HUGE_VAL
48 #else 43 #else
49 # define V8_INFINITY INFINITY 44 # define V8_INFINITY INFINITY
50 #endif 45 #endif
51 46
52 namespace v8 { 47 namespace v8 {
53 namespace internal { 48 namespace internal {
54 49
55 // Processor architecture detection. For more info on what's defined, see: 50 // Processor architecture detection. For more info on what's defined, see:
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 // the backend, so both modes are represented by the kStrictMode value. 425 // the backend, so both modes are represented by the kStrictMode value.
431 enum StrictModeFlag { 426 enum StrictModeFlag {
432 kNonStrictMode, 427 kNonStrictMode,
433 kStrictMode 428 kStrictMode
434 }; 429 };
435 430
436 431
437 } } // namespace v8::internal 432 } } // namespace v8::internal
438 433
439 #endif // V8_GLOBALS_H_ 434 #endif // V8_GLOBALS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698