Addressing sadruls comments from the previous CL https://codereview.chromium.org/22865036/ which was

ui/aura/root_window_unittest.cc

Index: ui/aura/root_window_unittest.cc
===================================================================
--- ui/aura/root_window_unittest.cc	(revision 219583)
+++ ui/aura/root_window_unittest.cc	(working copy)
@@ -908,4 +908,121 @@
   filter->events().clear();
 }
 
+// This class inherits from the EventFilterRecorder class which provides a
+// facility to record events. This class additionally provides a facility to
+// repost the ET_GESTURE_TAP_DOWN gesture to the target window and records
+// events after that.
+class RepostGestureEventRecorder : public EventFilterRecorder {
+ public:
+  RepostGestureEventRecorder(aura::Window* repost_source,
+                             aura::Window* repost_target)
+      : repost_source_(repost_source),
+        repost_target_(repost_target),
+        reposted_(false) {}
+

[sadrul, 2013/08/28 15:16:59]

You should add a virtual destructor here too.

[ananta, 2013/08/28 18:39:10]

Done.

+  virtual void OnGestureEvent(ui::GestureEvent* event) OVERRIDE {
+    EXPECT_EQ(reposted_ ? repost_target_ : repost_source_, event->target());
+    if (event->type() == ui::ET_GESTURE_TAP_DOWN) {
+      if (!reposted_) {
+        EXPECT_NE(repost_target_, event->target());
+        reposted_ = true;
+        events().clear();
+        repost_target_->GetRootWindow()->RepostEvent(*event);
+        // Ensure that the reposted gesture event above goes to the
+        // repost_target_;
+        repost_source_->GetRootWindow()->RemoveChild(repost_source_);
+        return;
+      }
+    }
+    EventFilterRecorder::OnGestureEvent(event);
+  }
+
+  // Ignore mouse events as they don't fire at all times. This causes
+  // the GestureRepostEventOrder test to fail randomly.
+  virtual void OnMouseEvent(ui::MouseEvent* event) OVERRIDE {
+    return;

[sadrul, 2013/08/28 15:16:59]

Don't need this.

[ananta, 2013/08/28 18:39:10]

Done.

+  }
+
+
+ private:
+  aura::Window* repost_source_;
+  aura::Window* repost_target_;
+  // set to true if we reposted the ET_GESTURE_TAP_DOWN event.
+  bool reposted_;
+  DISALLOW_COPY_AND_ASSIGN(RepostGestureEventRecorder);
+};
+
+// Tests whether events which are generated after the reposted gesture event
+// are received after that. In this case the scroll sequence events should
+// be received after the reposted gesture event.
+TEST_F(RootWindowTest, GestureRepostEventOrder) {
+  // Expected events at the end for the repost_target window defined below.
+  const ui::EventType kExpectedTargetEvents[] = {
+    ui::ET_GESTURE_BEGIN,
+    ui::ET_GESTURE_TAP_DOWN,
+    ui::ET_TOUCH_RELEASED,

[sadrul, 2013/08/28 15:16:59]

Do you know why we don't get a GESTURE_END here?

[ananta, 2013/08/28 18:39:10]

If you look at the RootWindow::ProcessGestures function, there is this
line:-
if (event_dispatch_target_ != target)  // |target| has been destroyed
  break;
The event_dispatch_target_ member is set to NULL because the
RepostGestureEventRecorder::OnGestureEvent function after reposting the tap down
gesture, removes the repost_source_ window from the root window.

[sadrul, 2013/08/28 18:44:43]

The first window is destroyed/removed from the RootWindow in response to the
touch-press/tap-down event. And the second window does receive the
TOUCH_RELEASED event. It's curious that it doesn't receive the GESTURE_END event
(which is generated from the TOUCH_RELEASED event). It'd be good to understand
why.

+    ui::ET_TOUCH_PRESSED,
+    ui::ET_GESTURE_BEGIN,
+    ui::ET_GESTURE_TAP_DOWN,
+    ui::ET_TOUCH_MOVED,
+    ui::ET_GESTURE_TAP_CANCEL,
+    ui::ET_GESTURE_SCROLL_BEGIN,
+    ui::ET_GESTURE_SCROLL_UPDATE,
+    ui::ET_TOUCH_MOVED,
+    ui::ET_GESTURE_SCROLL_UPDATE,
+    ui::ET_TOUCH_MOVED,
+    ui::ET_GESTURE_SCROLL_UPDATE,
+    ui::ET_TOUCH_RELEASED,
+    ui::ET_GESTURE_SCROLL_END,
+    ui::ET_GESTURE_END,
+  };
+  // We create two windows.
+  // The first window (repost_source) is the one to which the initial tap
+  // gesture is sent. It reposts this event to the second window
+  // (repost_target).
+  // We then generate the scroll sequence for repost_target and look for two
+  // ET_GESTURE_TAP_DOWN events in the event list at the end.
+  test::TestWindowDelegate delegate;
+  scoped_ptr<aura::Window> repost_target(CreateTestWindowWithDelegate(
+      &delegate, 1, gfx::Rect(0, 0, 100, 100), root_window()));
+
+  scoped_ptr<aura::Window> repost_source(CreateTestWindowWithDelegate(
+      &delegate, 1, gfx::Rect(0, 0, 50, 50), root_window()));
+
+  RepostGestureEventRecorder* repost_event_recorder =
+      new RepostGestureEventRecorder(repost_source.get(), repost_target.get());
+  root_window()->SetEventFilter(repost_event_recorder);  // passes ownership
+
+  // Generate a tap down gesture for the repost_source. This will be reposted
+  // to repost_target.
+  test::EventGenerator repost_generator(root_window(), repost_source.get());
+  repost_generator.GestureTapAt(gfx::Point(40, 40));
+  RunAllPendingInMessageLoop();
+
+  test::EventGenerator scroll_generator(root_window(), repost_target.get());
+  scroll_generator.GestureScrollSequence(
+      gfx::Point(80, 80),
+      gfx::Point(100, 100),
+      base::TimeDelta::FromMilliseconds(100),
+      3);
+  RunAllPendingInMessageLoop();
+
+  int tap_down_count = 0;
+  for (size_t i = 0; i < repost_event_recorder->events().size(); ++i) {
+    if (repost_event_recorder->events()[i] == ui::ET_GESTURE_TAP_DOWN)
+      ++tap_down_count;
+  }
+
+  // We expect two tap down events. One from the repost and the other one from
+  // the scroll sequence posted above.
+  EXPECT_EQ(tap_down_count, 2);
+
+  EXPECT_EQ(repost_event_recorder->events().size(),
+            arraysize(kExpectedTargetEvents));
+
+  EXPECT_EQ(memcmp(repost_event_recorder->events().data(),
+                   kExpectedTargetEvents,
+                   repost_event_recorder->events().size()), 0);

[sadrul, 2013/08/28 15:16:59]

Please go back to using EventTypeToString (it'd be easier to understand what
went wrong when the test fails with string outputs).

[ananta, 2013/08/28 18:39:10]

Done.

+}
+
 }  // namespace aura