Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.cpp - Issue 232013002: Rewind the DocumentLifecycle when dirtying state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.cpp

Issue 232013002: Rewind the DocumentLifecycle when dirtying state (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/DocumentLifecycle.cpp ('k') | Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.cpp » ('j') | Source/core/frame/FrameView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.cpp

diff --git a/Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.cpp b/Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.cpp

index daaec3a7575be6bd773135aaf0611af8cc281684..2e0d4a682c660a572c52c0be13ce3b7ff7841965 100644

--- a/Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.cpp

+++ b/Source/core/frame/DeprecatedScheduleStyleRecalcDuringCompositingUpdate.cpp

@@ -11,7 +11,7 @@ namespace WebCore {

DeprecatedScheduleStyleRecalcDuringCompositingUpdate::DeprecatedScheduleStyleRecalcDuringCompositingUpdate(DocumentLifecycle& lifecycle)

: m_lifecycle(lifecycle)

- , m_deprecatedTransition(lifecycle.state(), DocumentLifecycle::StyleRecalcPending)

+ , m_deprecatedTransition(lifecycle.state(), DocumentLifecycle::UpdatePending)

, m_originalState(lifecycle.state())

{

}

@@ -23,7 +23,7 @@ DeprecatedScheduleStyleRecalcDuringCompositingUpdate::~DeprecatedScheduleStyleRe

&& m_originalState != DocumentLifecycle::InCompositingUpdate)

return;

if (m_lifecycle.state() != m_originalState) {

- ASSERT(m_lifecycle.state() == DocumentLifecycle::StyleRecalcPending);

+ ASSERT(m_lifecycle.state() == DocumentLifecycle::UpdatePending);

m_lifecycle.advanceTo(m_originalState);

}