Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: dart/tools/testing/dart/test_suite.dart

Issue 23201019: Revert "Enable running multitests in browsers" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « dart/tests/lib/lib.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 628 matching lines...) Expand 10 before | Expand all | Expand 10 after
639 var isNegative = info.hasCompileError; 639 var isNegative = info.hasCompileError;
640 if (info.hasRuntimeError && hasRuntime) { 640 if (info.hasRuntimeError && hasRuntime) {
641 isNegative = true; 641 isNegative = true;
642 } 642 }
643 643
644 // Look up expectations in status files using a test name generated 644 // Look up expectations in status files using a test name generated
645 // from the test file's path. 645 // from the test file's path.
646 String testName; 646 String testName;
647 647
648 if (optionsFromFile['isMultitest']) { 648 if (optionsFromFile['isMultitest']) {
649 // Multitests do not run on browsers.
650 if (TestUtils.isBrowserRuntime(configuration['runtime'])) return;
649 // Multitests are in [build directory]/generated_tests/... . 651 // Multitests are in [build directory]/generated_tests/... .
650 // The test name will be '[test filename (no extension)]/[multitest key]. 652 // The test name will be '[test filename (no extension)]/[multitest key].
651 String name = filePath.filenameWithoutExtension; 653 String name = filePath.filenameWithoutExtension;
652 int middle = name.lastIndexOf('_'); 654 int middle = name.lastIndexOf('_');
653 testName = '${name.substring(0, middle)}/${name.substring(middle + 1)}'; 655 testName = '${name.substring(0, middle)}/${name.substring(middle + 1)}';
654 } else { 656 } else {
655 // The test name is the relative path from the test suite directory to 657 // The test name is the relative path from the test suite directory to
656 // the test, with the .dart extension removed. 658 // the test, with the .dart extension removed.
657 assert(filePath.toNativePath().startsWith( 659 assert(filePath.toNativePath().startsWith(
658 suiteDir.toNativePath())); 660 suiteDir.toNativePath()));
(...skipping 1227 matching lines...) Expand 10 before | Expand all | Expand 10 after
1886 */ 1888 */
1887 static Path get dartTestExecutable { 1889 static Path get dartTestExecutable {
1888 var path = '${TestUtils.dartDir()}/tools/testing/bin/' 1890 var path = '${TestUtils.dartDir()}/tools/testing/bin/'
1889 '${Platform.operatingSystem}/dart'; 1891 '${Platform.operatingSystem}/dart';
1890 if (Platform.operatingSystem == 'windows') { 1892 if (Platform.operatingSystem == 'windows') {
1891 path = '$path.exe'; 1893 path = '$path.exe';
1892 } 1894 }
1893 return new Path(path); 1895 return new Path(path);
1894 } 1896 }
1895 1897
1896 /** 1898 /**
1897 * Gets extra vm options passed to the testing script. 1899 * Gets extra vm options passed to the testing script.
1898 */ 1900 */
1899 static List<String> getExtraVmOptions(Map configuration) { 1901 static List<String> getExtraVmOptions(Map configuration) {
1900 var extraVmOptions = []; 1902 var extraVmOptions = [];
1901 if (configuration['vm-options'] != null) { 1903 if (configuration['vm-options'] != null) {
1902 extraVmOptions = configuration['vm-options'].split(" "); 1904 extraVmOptions = configuration['vm-options'].split(" ");
1903 extraVmOptions.removeWhere((s) => s.trim() == ""); 1905 extraVmOptions.removeWhere((s) => s.trim() == "");
1904 } 1906 }
1905 return extraVmOptions; 1907 return extraVmOptions;
1906 } 1908 }
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
1963 * $pass tests are expected to pass 1965 * $pass tests are expected to pass
1964 * $failOk tests are expected to fail that we won't fix 1966 * $failOk tests are expected to fail that we won't fix
1965 * $fail tests are expected to fail that we should fix 1967 * $fail tests are expected to fail that we should fix
1966 * $crash tests are expected to crash that we should fix 1968 * $crash tests are expected to crash that we should fix
1967 * $timeout tests are allowed to timeout 1969 * $timeout tests are allowed to timeout
1968 * $compileErrorSkip tests are skipped on browsers due to compile-time error 1970 * $compileErrorSkip tests are skipped on browsers due to compile-time error
1969 """; 1971 """;
1970 print(report); 1972 print(report);
1971 } 1973 }
1972 } 1974 }
OLDNEW
« no previous file with comments | « dart/tests/lib/lib.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698