Issue 23201009: [Autofill] Cleanup disabled Tests

Issue 23201009: [Autofill] Cleanup disabled Tests (Closed)

Created:
7 years, 4 months ago by csharp

Modified:
7 years, 3 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Autofill] Cleanup disabled Tests I tried to make some progress fixing the flake in these tests, but I didn't make any headway (I'll email you my results to see what the next steps should be). I did find a few bugs in the tests though so just fixed them up. BUG=150084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220230

Patch Set 1 : #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+247 lines, -518 lines)			Patch
M	chrome/browser/autofill/autofill_browsertest.cc	View	4 chunks	+7 lines, -3 lines	0 comments	Download
D	chrome/test/data/autofill/dataset.txt	View	1 chunk	+0 lines, -250 lines	0 comments	Download
D	chrome/test/data/autofill/dataset_2.txt	View	1 chunk	+0 lines, -19 lines	0 comments	Download
A +	chrome/test/data/autofill/dataset_duplicated_profiles.txt	View	1 chunk	+241 lines, -247 lines	1 comment	Download
A +	chrome/test/data/autofill/dataset_same_address.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csharp

https://codereview.chromium.org/23201009/diff/11001/chrome/test/data/autofill/dataset_duplicated_profiles.txt File chrome/test/data/autofill/dataset_duplicated_profiles.txt (right): https://codereview.chromium.org/23201009/diff/11001/chrome/test/data/autofill/dataset_duplicated_profiles.txt#newcode3 chrome/test/data/autofill/dataset_duplicated_profiles.txt:3: # first_name, middle_name, last_name, email, company_name, address_line_1, address_line_2, city, ...

7 years, 3 months ago (2013-08-28 14:55:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/23201009/11001

7 years, 3 months ago (2013-08-29 00:37:32 UTC) #4

Message was sent while issue was closed.

Change committed as 220230

Expand Messages | Collapse Messages