|
|
DescriptionFixed access to `constraint_flags` array in ParseHEVCCodecId function.
This patch adds necessary offset when accessing this array.
`constraint_flags` is an array of 6 elements, however in
`for` loop it can be accessed with indices from 4 to 9
instead of indices from 0 to 5.
Committed: https://crrev.com/ab6511817745073222efa81cd6627c13cb667628
Cr-Commit-Position: refs/heads/master@{#417351}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== Fixed access to `constraint_flags` array in ParseHEVCCodecId function. This patch adds necessary offset for array's indices. `constraint_flags` is an array of 6 elements, however in `for` loop it can be accessed with indices from 4 to 9 instead of indices from 0 to 5. ========== to ========== Fixed access to `constraint_flags` array in ParseHEVCCodecId function. This patch adds necessary offset when accessing this array. `constraint_flags` is an array of 6 elements, however in `for` loop it can be accessed with indices from 4 to 9 instead of indices from 0 to 5. ==========
ddyndo@opera.com changed reviewers: + qinmin@chromium.org, wolenetz@chromium.org
ddyndo@opera.com changed reviewers: + servolk@chromium.org
@reviewer: does this fix look OK to you?
servolk@chromium.org changed reviewers: + chcunningham@chromium.org
On 2016/09/08 09:26:56, ddyndo wrote: > @reviewer: does this fix look OK to you? Yes, good catch, thank you. Media owners, can you please approve this?
The CQ bit was checked by servolk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dalecurtis@chromium.org changed reviewers: + dalecurtis@chromium.org
lgtm
also lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by servolk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fixed access to `constraint_flags` array in ParseHEVCCodecId function. This patch adds necessary offset when accessing this array. `constraint_flags` is an array of 6 elements, however in `for` loop it can be accessed with indices from 4 to 9 instead of indices from 0 to 5. ========== to ========== Fixed access to `constraint_flags` array in ParseHEVCCodecId function. This patch adds necessary offset when accessing this array. `constraint_flags` is an array of 6 elements, however in `for` loop it can be accessed with indices from 4 to 9 instead of indices from 0 to 5. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fixed access to `constraint_flags` array in ParseHEVCCodecId function. This patch adds necessary offset when accessing this array. `constraint_flags` is an array of 6 elements, however in `for` loop it can be accessed with indices from 4 to 9 instead of indices from 0 to 5. ========== to ========== Fixed access to `constraint_flags` array in ParseHEVCCodecId function. This patch adds necessary offset when accessing this array. `constraint_flags` is an array of 6 elements, however in `for` loop it can be accessed with indices from 4 to 9 instead of indices from 0 to 5. Committed: https://crrev.com/ab6511817745073222efa81cd6627c13cb667628 Cr-Commit-Position: refs/heads/master@{#417351} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ab6511817745073222efa81cd6627c13cb667628 Cr-Commit-Position: refs/heads/master@{#417351} |