Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Issue 2320063002: Fixed access to `constraint_flags` array in ParseHEVCCodecId function. (Closed)

Created:
4 years, 3 months ago by ddyndo
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, Mostyn Bramley-Moore, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed access to `constraint_flags` array in ParseHEVCCodecId function. This patch adds necessary offset when accessing this array. `constraint_flags` is an array of 6 elements, however in `for` loop it can be accessed with indices from 4 to 9 instead of indices from 0 to 5. Committed: https://crrev.com/ab6511817745073222efa81cd6627c13cb667628 Cr-Commit-Position: refs/heads/master@{#417351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/base/video_codecs.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
ddyndo
@reviewer: does this fix look OK to you?
4 years, 3 months ago (2016-09-08 09:26:56 UTC) #4
servolk
On 2016/09/08 09:26:56, ddyndo wrote: > @reviewer: does this fix look OK to you? Yes, ...
4 years, 3 months ago (2016-09-08 16:51:56 UTC) #6
DaleCurtis
lgtm
4 years, 3 months ago (2016-09-08 17:06:27 UTC) #10
wolenetz
also lgtm
4 years, 3 months ago (2016-09-08 17:31:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320063002/1
4 years, 3 months ago (2016-09-08 18:45:32 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 18:50:38 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 18:52:17 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab6511817745073222efa81cd6627c13cb667628
Cr-Commit-Position: refs/heads/master@{#417351}

Powered by Google App Engine
This is Rietveld 408576698