|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Ken Russell (switch to Gerrit) Modified:
4 years, 3 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, vmiura Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDeploy Mac ASAN bot on chromium.gpu.fyi waterfall.
Refactored mb's mixins for the GPU FYI tests and bots to make this
simpler.
Removed the Mac-10.10 specialization for jobs launched on the MacBook
Pros with AMD GPUs, to allow them to be upgraded to 10.11.
BUG=641066, 644920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=dpranke@chromium.org,zmo@chromium.org
NOTRY=true
Committed: https://crrev.com/e4444ef6d703c3efd42f0961c8786aca35f574b7
Cr-Commit-Position: refs/heads/master@{#417744}
Patch Set 1 #Patch Set 2 : Rebased (not sure it was required). #Patch Set 3 : Reran buildbot generation script. #
Messages
Total messages: 29 (14 generated)
Description was changed from ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 ========== to ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
kbr@chromium.org changed reviewers: + dpranke@chromium.org, zmo@chromium.org
Dirk, Mo: FYI. I'm CQ'ing this TBR'd in the hope I can restart the chromium.gpu.fyi waterfall later tonight to add the new bot.
Description was changed from ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=dpranke@chromium.org,zmo@chromium.org ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
lgtm
On 2016/09/08 04:51:19, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...) One of the shards of webgl2_conformance_tests took out the Mac Mini. I filed http://crbug.com/645280 about that fact and http://crbug.com/645279 about putting 20 quarantined Mac Minis back into the Swarming pool. The Windows failures were http://crbug.com/633067 . I commented on that bug.
On 2016/09/08 22:50:31, Ken Russell wrote: > On 2016/09/08 04:51:19, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...) > > One of the shards of webgl2_conformance_tests took out the Mac Mini. I filed > http://crbug.com/645280 about that fact and http://crbug.com/645279 about > putting 20 quarantined Mac Minis back into the Swarming pool. > > The Windows failures were http://crbug.com/633067 . I commented on that bug. It turns out that my earlier tryjobs neglected to run the macOS changes. I'm going to try landing this through the CQ one more time.
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2320023002/#ps40001 (title: "Reran buildbot generation script.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/09/08 23:10:19, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux > (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) > linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux > (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Reverted the broken patch in https://codereview.chromium.org/2320323002/ .
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
On 2016/09/09 22:34:27, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) This is http://crbug.com/633067 and is unrelated to this change. At this point I'm bypassing the CQ to get this change in.
Description was changed from ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=dpranke@chromium.org,zmo@chromium.org ========== to ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=dpranke@chromium.org,zmo@chromium.org NOTRY=true ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=dpranke@chromium.org,zmo@chromium.org NOTRY=true ========== to ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=dpranke@chromium.org,zmo@chromium.org NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=dpranke@chromium.org,zmo@chromium.org NOTRY=true ========== to ========== Deploy Mac ASAN bot on chromium.gpu.fyi waterfall. Refactored mb's mixins for the GPU FYI tests and bots to make this simpler. Removed the Mac-10.10 specialization for jobs launched on the MacBook Pros with AMD GPUs, to allow them to be upgraded to 10.11. BUG=641066, 644920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=dpranke@chromium.org,zmo@chromium.org NOTRY=true Committed: https://crrev.com/e4444ef6d703c3efd42f0961c8786aca35f574b7 Cr-Commit-Position: refs/heads/master@{#417744} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/e4444ef6d703c3efd42f0961c8786aca35f574b7 Cr-Commit-Position: refs/heads/master@{#417744} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
