Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2320013002: [turbofan] Revert "Avoid overflow checks on SpeculativeNumberAdd/Subtract/Multiply." (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Revert "Avoid overflow checks on SpeculativeNumberAdd/Subtract/Multiply." The optimization is not correct for unsigned output types, and we the overall complexity seems too high. We need to find a better way to take into account the input/output type restrictions. Also added a regression test for the unsigned output bug. BUG=v8:5267, v8:5270, v8:5357 TBR=jarin@chromium.org Committed: https://crrev.com/91ed540ee662e15a9a33a420848f2e171f2999d1 Cr-Commit-Position: refs/heads/master@{#39262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -90 lines) Patch
M src/compiler/representation-change.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 10 chunks +68 lines, -77 lines 0 comments Download
A + test/mjsunit/regress/regress-5357.js View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-08 03:47:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320013002/1
4 years, 3 months ago (2016-09-08 03:47:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 04:20:22 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 04:20:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91ed540ee662e15a9a33a420848f2e171f2999d1
Cr-Commit-Position: refs/heads/master@{#39262}

Powered by Google App Engine
This is Rietveld 408576698