Issue 232001: Resubmitting fix for 22174

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232001: Resubmitting fix for 22174 (Closed)

Created:
11 years, 3 months ago by Andrew T Wilson (Slow)

Modified:
9 years, 7 months ago

Reviewers:
levin

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, darin (slow to review), jam, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Un-reverting 26919, and disabling worker-cloneports since it is flaky. Added missing layout tests along with associated rebaselinings. Updated DEPS to include common resource files needed by tests, and add APIs to ui_layout_test to allow specifying resource files to copy. Disabled non-working tests so we can enable worker_uitests on Mac/Linux. BUG=22174 TEST=worker_uitest

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, --1 lines)			Patch
M	DEPS	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/test/ui/ui_layout_test.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/ui/ui_layout_test.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	chrome/worker/worker_uitest.cc	View	1	8 chunks	+46 lines, -1 line	0 comments	Download
A +	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/events/message-port-multi-expected.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/workers/worker-context-multi-port-expected.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/workers/worker-multi-port-expected.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

This is the same patch you LGTM'd last night, but with a flaky test commented ...

11 years, 3 months ago (2009-09-23 22:12:07 UTC) #1

LGTM

Expand Messages | Collapse Messages