Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2320003002: DevTools: reuse ephemeral port from http handler in the shell front-end. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: reuse ephemeral port from http handler in the shell front-end. BUG= Committed: https://crrev.com/f7c18d02484a42d05f4e2f702d52a09727c2e637 Cr-Commit-Position: refs/heads/master@{#417371}

Patch Set 1 #

Patch Set 2 : includes removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M content/shell/browser/shell_devtools_frontend.cc View 1 3 chunks +1 line, -17 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_devtools_manager_delegate.cc View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
4 years, 3 months ago (2016-09-08 01:33:16 UTC) #2
dgozman
lgtm Please attribute to a bug.
4 years, 3 months ago (2016-09-08 16:55:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320003002/20001
4 years, 3 months ago (2016-09-08 18:58:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 19:54:44 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 19:58:59 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f7c18d02484a42d05f4e2f702d52a09727c2e637
Cr-Commit-Position: refs/heads/master@{#417371}

Powered by Google App Engine
This is Rietveld 408576698