chrome/browser/renderer_host/chrome_render_view_host_observer.cc - Issue 23200006: Don't show the search-by-image menu item when the image is blocked (no image pixel data)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/chrome_render_view_host_observer.cc

Issue 23200006: Don't show the search-by-image menu item when the image is blocked (no image pixel data) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: use ContextMenuParams::has_image_contents to check image's availability Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/chrome_render_view_host_observer.cc

===================================================================

--- chrome/browser/renderer_host/chrome_render_view_host_observer.cc (revision 218359)

+++ chrome/browser/renderer_host/chrome_render_view_host_observer.cc (working copy)

@@ -206,6 +206,8 @@

// request based on the received thumbnail and opens the request in a new tab.

void ChromeRenderViewHostObserver::OnRequestThumbnailForContextNodeACK(

const SkBitmap& bitmap) {

+ if (bitmap.isNull())

+ return;

WebContents* web_contents =

WebContents::FromRenderViewHost(render_view_host());

const TemplateURL* const default_provider =

« no previous file with comments | « no previous file | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | chrome/browser/tab_contents/render_view_context_menu.cc » ('J')