[USS] Implement SharedModelTypeProcessor::GetAllNodes for USS

components/sync/protocol/proto_value_conversions.cc

Index: components/sync/protocol/proto_value_conversions.cc
diff --git a/components/sync/protocol/proto_value_conversions.cc b/components/sync/protocol/proto_value_conversions.cc
index 1397db8c44cb38528c8e65f9794e899606cd3578..0843275c3c2b83ea080448f1bfabbd654a6572a5 100644
--- a/components/sync/protocol/proto_value_conversions.cc
+++ b/components/sync/protocol/proto_value_conversions.cc
@@ -29,6 +29,7 @@
 #include "components/sync/protocol/bookmark_specifics.pb.h"
 #include "components/sync/protocol/dictionary_specifics.pb.h"
 #include "components/sync/protocol/encryption.pb.h"
+#include "components/sync/protocol/entity_metadata.pb.h"

[skym, 2016/09/12 16:40:39]

This is dangerous. I'm not sure if this file syncs/needs to be synced with the
server copy of these proto files, but EntityMetadata is currently (but should
not be) synced with the source files the server uses. Adding this dependency is
a potential hazard if one day we clean things up and stop sharing
EntityMetadata. Can you figure out if proto_value_conversions.cc should be
shared and if so, leave comments making this hazard clear?

[Gang Wu, 2016/09/12 22:38:04]

Acknowledged.

 #include "components/sync/protocol/experiments_specifics.pb.h"
 #include "components/sync/protocol/extension_setting_specifics.pb.h"
 #include "components/sync/protocol/extension_specifics.pb.h"
@@ -1090,6 +1091,22 @@ std::unique_ptr<base::DictionaryValue> AttachmentIdProtoToValue(
   return value;
 }
 
+std::unique_ptr<base::DictionaryValue> EntityMetadataToValue(
+    const sync_pb::EntityMetadata& proto) {
+  std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue());
+  SET_STR(client_tag_hash);
+  SET_STR(server_id);
+  SET_BOOL(is_deleted);
+  SET_INT64(sequence_number);
+  SET_INT64(acked_sequence_number);
+  SET_INT64(server_version);
+  SET_INT64(creation_time);
+  SET_INT64(modification_time);
+  SET_STR(specifics_hash);
+  SET_STR(base_specifics_hash);
+  return value;
+}
+
 #undef SET_TYPE
 #undef SET
 #undef SET_REP