[USS] Implement SharedModelTypeProcessor::GetAllNodes for USS

components/sync/api/entity_data.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/api/entity_data.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_util.h"
+#include "components/sync/base/time.h"
+#include "components/sync/base/unique_position.h"
+#include "components/sync/protocol/proto_value_conversions.h"
 
 namespace syncer_v2 {
 
+namespace {

[pavely, 2016/09/14 17:15:30]

nit: new line after "namespace syncer_v2 {" and before "}  // namespace"

[maxbogue, 2016/09/14 17:58:02]

Since there's already a newline after namespace syncer_v2, I assume pavel means
after "namespace {"

[Gang Wu, 2016/09/15 17:12:47]

Done.

[Gang Wu, 2016/09/15 17:12:47]

Done.

+std::string UniquePositionToString(
+    const sync_pb::UniquePosition& unique_position) {
+  return syncer::UniquePosition::FromProto(unique_position).ToDebugString();
+}
+}  // namespace
+
 EntityData::EntityData() {}
 EntityData::~EntityData() {}
 
 void EntityData::Swap(EntityData* other) {
   id.swap(other->id);
   client_tag_hash.swap(other->client_tag_hash);
   non_unique_name.swap(other->non_unique_name);
 
   specifics.Swap(&other->specifics);
 
   std::swap(creation_time, other->creation_time);
   std::swap(modification_time, other->modification_time);
 
   parent_id.swap(other->parent_id);
   unique_position.Swap(&other->unique_position);
 }
 
 EntityDataPtr EntityData::PassToPtr() {
   EntityDataPtr target;
   target.swap_value(this);
   return target;
 }
 
+#define ADD_TO_DICT(dict, value, transform) \

[maxbogue, 2016/09/14 17:58:02]

Despite this being how proto_value_conversions does it, I still think it would
be more readable without the macro.

[Gang Wu, 2016/09/15 17:12:47]

Acknowledged.

+  dict->SetString(base::ToUpperASCII(#value), transform(value));
+
+std::unique_ptr<base::DictionaryValue> EntityData::ToDictionaryValue() {
+  std::unique_ptr<base::DictionaryValue> dict =
+      syncer::EntitySpecificsToValue(specifics);
+  ADD_TO_DICT(dict, id, );
+  ADD_TO_DICT(dict, client_tag_hash, );
+  ADD_TO_DICT(dict, non_unique_name, );
+  ADD_TO_DICT(dict, parent_id, );
+  ADD_TO_DICT(dict, creation_time, syncer::GetTimeDebugString);
+  ADD_TO_DICT(dict, modification_time, syncer::GetTimeDebugString);
+  ADD_TO_DICT(dict, unique_position, UniquePositionToString);
+  return dict;
+}
+
+#undef ADD_TO_DICT
+
 void EntityDataTraits::SwapValue(EntityData* dest, EntityData* src) {
   dest->Swap(src);
 }
 
 bool EntityDataTraits::HasValue(const EntityData& value) {
   return !value.client_tag_hash.empty();
 }
 
 const EntityData& EntityDataTraits::DefaultValue() {
   CR_DEFINE_STATIC_LOCAL(EntityData, default_instance, ());
   return default_instance;
 }
 
 }  // namespace syncer_v2