ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc - Issue 2319933002: X11: Remove calls to XSelectInput

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Issue 2319933002: X11: Remove calls to XSelectInput (Closed)

Patch Set: Change mask stuff in window_tree_host_x11, remove XSelectInput in ui/compositor, update dependent patch set Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/aura/window_tree_host_x11.cc ('K') | « ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h ('k') | ui/views/widget/desktop_aura/x11_desktop_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

index d45f8324f13d56b57002ca31217e1e771656cdd3..393cb98799c29f462fbd80c46abe75cccc221388 100644

--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

@@ -32,6 +32,7 @@

#include "ui/base/ime/input_method.h"

#include "ui/base/x/x11_util.h"

#include "ui/base/x/x11_util_internal.h"

+#include "ui/base/x/x11_window_event_manager.h"

#include "ui/display/display.h"

#include "ui/display/screen.h"

#include "ui/events/devices/x11/device_data_manager_x11.h"

@@ -1396,7 +1397,7 @@ void DesktopWindowTreeHostX11::InitX11Window(

ExposureMask | VisibilityChangeMask |

StructureNotifyMask | PropertyChangeMask |

PointerMotionMask;

- XSelectInput(xdisplay_, xwindow_, event_mask);

+ xwindow_events_.reset(new ui::XScopedEventSelector(xwindow_, event_mask));

XFlush(xdisplay_);

if (ui::IsXInput2Available())