content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java - Issue 2319903003: Don't expose Android set selection accessibility action for empty text fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 2319903003: Don't expose Android set selection accessibility action for empty text fields (Closed)

Patch Set: Update one test expectation Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

index e78877d3185e26f51c6c6a6c2be261de9a8af869..1c34c0fc34a55cbe923123d1ab9b62800e53409a 100644

--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

@@ -816,18 +816,24 @@ public class BrowserAccessibilityManager {

int virtualViewId, boolean canScrollForward, boolean canScrollBackward,

boolean canScrollUp, boolean canScrollDown, boolean canScrollLeft,

boolean canScrollRight, boolean clickable, boolean editableText, boolean enabled,

- boolean focusable, boolean focused, boolean isCollapsed, boolean isExpanded) {

+ boolean focusable, boolean focused, boolean isCollapsed, boolean isExpanded,

+ boolean hasNonEmptyValue) {

node.addAction(AccessibilityNodeInfo.ACTION_NEXT_HTML_ELEMENT);

node.addAction(AccessibilityNodeInfo.ACTION_PREVIOUS_HTML_ELEMENT);

node.addAction(AccessibilityNodeInfo.ACTION_NEXT_AT_MOVEMENT_GRANULARITY);

node.addAction(AccessibilityNodeInfo.ACTION_PREVIOUS_AT_MOVEMENT_GRANULARITY);

if (editableText && enabled) {

+ // TODO: don't support actions that modify it if it's read-only (but

+ // SET_SELECTION and COPY are okay).

node.addAction(ACTION_SET_TEXT);

- node.addAction(AccessibilityNodeInfo.ACTION_SET_SELECTION);

- node.addAction(AccessibilityNodeInfo.ACTION_CUT);

- node.addAction(AccessibilityNodeInfo.ACTION_COPY);

node.addAction(AccessibilityNodeInfo.ACTION_PASTE);

+ if (hasNonEmptyValue) {

+ node.addAction(AccessibilityNodeInfo.ACTION_SET_SELECTION);

+ node.addAction(AccessibilityNodeInfo.ACTION_CUT);

+ node.addAction(AccessibilityNodeInfo.ACTION_COPY);

+ }

}

if (canScrollForward) {