Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 2319903003: Don't expose Android set selection accessibility action for empty text fields (Closed)
Patch Set: Update one test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc
index 991cf010d1fdacd439e518233aeabe27b3dd6c25..028d76d2bc4e4fe2777da635d0c436869305a37e 100644
--- a/content/browser/accessibility/browser_accessibility_android.cc
+++ b/content/browser/accessibility/browser_accessibility_android.cc
@@ -1343,6 +1343,10 @@ bool BrowserAccessibilityAndroid::HasFocusableChild() const {
return false;
}
+bool BrowserAccessibilityAndroid::HasNonEmptyValue() const {
+ return IsEditableText() && !GetValue().empty();
+}
+
bool BrowserAccessibilityAndroid::HasOnlyTextChildren() const {
// This is called from PlatformIsLeaf, so don't call PlatformChildCount
// from within this!

Powered by Google App Engine
This is Rietveld 408576698