Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 2319903003: Don't expose Android set selection accessibility action for empty text fields (Closed)
Patch Set: Update one test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility.cc
diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc
index afcbd0036fbe1744e568e722ac7dccf037373ba2..62f366258ea2a16b2695b4a2abb4ec3d9af7fcf0 100644
--- a/content/browser/accessibility/browser_accessibility.cc
+++ b/content/browser/accessibility/browser_accessibility.cc
@@ -520,7 +520,9 @@ base::string16 BrowserAccessibility::GetValue() const {
// Some screen readers like Jaws and older versions of VoiceOver require a
// value to be set in text fields with rich content, even though the same
// information is available on the children.
- if (value.empty() && (IsSimpleTextControl() || IsRichTextControl()))
+ if (value.empty() &&
+ (IsSimpleTextControl() || IsRichTextControl()) &&
+ !IsNativeTextControl())
value = GetInnerText();
return value;
}

Powered by Google App Engine
This is Rietveld 408576698