content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java - Issue 2319903003: Don't expose Android set selection accessibility action for empty text fields

Unified Diff: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

Issue 2319903003: Don't expose Android set selection accessibility action for empty text fields (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« content/browser/accessibility/browser_accessibility_manager_android.cc ('K') | « content/browser/accessibility/browser_accessibility_manager_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

index e78877d3185e26f51c6c6a6c2be261de9a8af869..f1df86017b9ce5aa4f8615711564af5a3a74ad38 100644

--- a/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

+++ b/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java

@@ -816,7 +816,8 @@ public class BrowserAccessibilityManager {

int virtualViewId, boolean canScrollForward, boolean canScrollBackward,

boolean canScrollUp, boolean canScrollDown, boolean canScrollLeft,

boolean canScrollRight, boolean clickable, boolean editableText, boolean enabled,

- boolean focusable, boolean focused, boolean isCollapsed, boolean isExpanded) {

+ boolean focusable, boolean focused, boolean isCollapsed, boolean isExpanded,

+ boolean hasNonEmptyValue) {

node.addAction(AccessibilityNodeInfo.ACTION_NEXT_HTML_ELEMENT);

node.addAction(AccessibilityNodeInfo.ACTION_PREVIOUS_HTML_ELEMENT);

node.addAction(AccessibilityNodeInfo.ACTION_NEXT_AT_MOVEMENT_GRANULARITY);

@@ -824,10 +825,13 @@ public class BrowserAccessibilityManager {

if (editableText && enabled) {

node.addAction(ACTION_SET_TEXT);

- node.addAction(AccessibilityNodeInfo.ACTION_SET_SELECTION);

- node.addAction(AccessibilityNodeInfo.ACTION_CUT);

- node.addAction(AccessibilityNodeInfo.ACTION_COPY);

node.addAction(AccessibilityNodeInfo.ACTION_PASTE);

+ if (hasNonEmptyValue) {

David Tseng 2016/09/08 20:49:47 How about read-only text fields?

dmazzoni 2016/10/05 19:40:48 Hmmm, it seems to me that you still ought to be ab

+ node.addAction(AccessibilityNodeInfo.ACTION_SET_SELECTION);

+ node.addAction(AccessibilityNodeInfo.ACTION_CUT);

+ node.addAction(AccessibilityNodeInfo.ACTION_COPY);

+ }

}

if (canScrollForward) {