Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: content/browser/accessibility/accessibility_tree_formatter_android.cc

Issue 2319903003: Don't expose Android set selection accessibility action for empty text fields (Closed)
Patch Set: Update one test expectation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/accessibility/accessibility_tree_formatter.h" 5 #include "content/browser/accessibility/accessibility_tree_formatter.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 17 matching lines...) Expand all
28 "checked", 28 "checked",
29 "clickable", 29 "clickable",
30 "collection", 30 "collection",
31 "collection_item", 31 "collection_item",
32 "content_invalid", 32 "content_invalid",
33 "disabled", 33 "disabled",
34 "dismissable", 34 "dismissable",
35 "editable_text", 35 "editable_text",
36 "focusable", 36 "focusable",
37 "focused", 37 "focused",
38 "has_non_empty_value",
38 "heading", 39 "heading",
39 "hierarchical", 40 "hierarchical",
40 "invisible", 41 "invisible",
41 "link", 42 "link",
42 "multiline", 43 "multiline",
43 "password", 44 "password",
44 "range", 45 "range",
45 "scrollable", 46 "scrollable",
46 "selected" 47 "selected"
47 }; 48 };
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 dict->SetBoolean("checkable", android_node->IsCheckable()); 111 dict->SetBoolean("checkable", android_node->IsCheckable());
111 dict->SetBoolean("checked", android_node->IsChecked()); 112 dict->SetBoolean("checked", android_node->IsChecked());
112 dict->SetBoolean("clickable", android_node->IsClickable()); 113 dict->SetBoolean("clickable", android_node->IsClickable());
113 dict->SetBoolean("collection", android_node->IsCollection()); 114 dict->SetBoolean("collection", android_node->IsCollection());
114 dict->SetBoolean("collection_item", android_node->IsCollectionItem()); 115 dict->SetBoolean("collection_item", android_node->IsCollectionItem());
115 dict->SetBoolean("disabled", !android_node->IsEnabled()); 116 dict->SetBoolean("disabled", !android_node->IsEnabled());
116 dict->SetBoolean("dismissable", android_node->IsDismissable()); 117 dict->SetBoolean("dismissable", android_node->IsDismissable());
117 dict->SetBoolean("editable_text", android_node->IsEditableText()); 118 dict->SetBoolean("editable_text", android_node->IsEditableText());
118 dict->SetBoolean("focusable", android_node->IsFocusable()); 119 dict->SetBoolean("focusable", android_node->IsFocusable());
119 dict->SetBoolean("focused", android_node->IsFocused()); 120 dict->SetBoolean("focused", android_node->IsFocused());
121 dict->SetBoolean("has_non_empty_value", android_node->HasNonEmptyValue());
120 dict->SetBoolean("heading", android_node->IsHeading()); 122 dict->SetBoolean("heading", android_node->IsHeading());
121 dict->SetBoolean("hierarchical", android_node->IsHierarchical()); 123 dict->SetBoolean("hierarchical", android_node->IsHierarchical());
122 dict->SetBoolean("invisible", !android_node->IsVisibleToUser()); 124 dict->SetBoolean("invisible", !android_node->IsVisibleToUser());
123 dict->SetBoolean("link", android_node->IsLink()); 125 dict->SetBoolean("link", android_node->IsLink());
124 dict->SetBoolean("multiline", android_node->IsMultiLine()); 126 dict->SetBoolean("multiline", android_node->IsMultiLine());
125 dict->SetBoolean("range", android_node->IsRangeType()); 127 dict->SetBoolean("range", android_node->IsRangeType());
126 dict->SetBoolean("password", android_node->IsPassword()); 128 dict->SetBoolean("password", android_node->IsPassword());
127 dict->SetBoolean("scrollable", android_node->IsScrollable()); 129 dict->SetBoolean("scrollable", android_node->IsScrollable());
128 dict->SetBoolean("selected", android_node->IsSelected()); 130 dict->SetBoolean("selected", android_node->IsSelected());
129 131
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
224 226
225 const std::string AccessibilityTreeFormatterAndroid::GetAllowString() { 227 const std::string AccessibilityTreeFormatterAndroid::GetAllowString() {
226 return "@ANDROID-ALLOW:"; 228 return "@ANDROID-ALLOW:";
227 } 229 }
228 230
229 const std::string AccessibilityTreeFormatterAndroid::GetDenyString() { 231 const std::string AccessibilityTreeFormatterAndroid::GetDenyString() {
230 return "@ANDROID-DENY:"; 232 return "@ANDROID-DENY:";
231 } 233 }
232 234
233 } // namespace content 235 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/accessibility/browser_accessibility.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698