Don't expose Android set selection accessibility action for empty text fields

content/browser/accessibility/browser_accessibility_manager_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility_manager_android.h"
 
 #include <stddef.h>
 
 #include <cmath>
 
@@ skipping 406 matching lines @@
       node->CanScrollUp(),
       node->CanScrollDown(),
       node->CanScrollLeft(),
       node->CanScrollRight(),
       node->IsClickable(),
       node->IsEditableText(),
       node->IsEnabled(),
       node->IsFocusable(),
       node->IsFocused(),
       node->IsCollapsed(),
-      node->IsExpanded());
+      node->IsExpanded(),
+      !node->GetValue().empty());

[David Tseng, 2016/09/08 20:49:47]

If I understand the bug correctly, don't you want to check for the placeholder
attribute here?

[dmazzoni, 2016/10/05 19:40:48]

No, because placeholder was just one possible example of an accessible label for
the text field. The real issue is that we want to know whether it has a value or
not.

There was a bug in GetValue, though - it was sometimes returning inner text. I
fixed that and added tests.

[David Tseng, 2016/10/06 16:27:58]

Value comes from value description and string value in Blink. Value description
uses aria value text which I guess isn't selectable. String value uses the text
value of the text field which is selectable. If the node is a select, it uses
aria label, which isn't selectable.

In conclusion, I don't think value is a good indicator of what's selectable or
not. Also, are you expecting this gets called only on text fields? Is Talkback
thinking about supporting dom selections? Might be nice to be able to select a
link, for example, to paste into a Doc.

   Java_BrowserAccessibilityManager_setAccessibilityNodeInfoClassName(
       env, obj, info,
       base::android::ConvertUTF8ToJavaString(env, node->GetClassName()));
   Java_BrowserAccessibilityManager_setAccessibilityNodeInfoText(
       env, obj, info,
       base::android::ConvertUTF16ToJavaString(env, node->GetText()),
       node->IsLink(), node->IsEditableText());
   base::string16 element_id;
   if (node->GetHtmlAttribute("id", &element_id)) {
     Java_BrowserAccessibilityManager_setAccessibilityNodeInfoViewIdResourceName(
@@ skipping 505 matching lines @@
 
   JNIEnv* env = AttachCurrentThread();
   return root_manager->java_ref().get(env);
 }
 
 bool RegisterBrowserAccessibilityManager(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content