Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2319893002: Merge "arc: Defer notification surface creation" (Closed)

Created:
4 years, 3 months ago by xiyuan
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge "arc: Defer notification surface creation" > - Add Create/CloseNotificationWindow to NotificationsInstance; > - ArcCustomNotificationItem tracks a window count for the views and > sends Create/CloseNotificationWindow based on the count; > - ArcCustomNotificationItem initializes the view with snapshot image; > - ArcCustomNotificationView observes surface manager and dynamically > switch from snapshot to live surface; > > BUG=640305, 640356 > BUG=b/30864565 > TEST=Manual. Custom notification works as before and CTS passes. > > Review-Url: https://codereview.chromium.org/2269403004 > Cr-Commit-Position: refs/heads/master@{#415887} > (cherry picked from commit a21cae6cb172afe362f8a6d12f6e64ce56347b65) Committed: https://chromium.googlesource.com/chromium/src/+/86512411d5d6937aa21a30d3dc893ee37a352df1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -79 lines) Patch
M components/arc/common/notifications.mojom View 3 chunks +14 lines, -1 line 0 comments Download
M components/arc/test/fake_notifications_instance.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/arc/test/fake_notifications_instance.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_item.h View 2 chunks +16 lines, -13 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_item.cc View 6 chunks +22 lines, -36 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.h View 4 chunks +19 lines, -8 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_view.cc View 8 chunks +93 lines, -20 lines 0 comments Download
M ui/arc/notification/arc_notification_item.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/arc/notification/arc_notification_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/arc/notification/arc_notification_manager.cc View 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
4 years, 3 months ago (2016-09-07 21:22:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86512411d5d6937aa21a30d3dc893ee37a352df1 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698