Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2319863005: Implement new compositor and ContentViewCore reparenting for VR Shell. (Closed)
Patch Set: Address comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 430315ba541563110d5ccdc95960ea074ee32729..cb45073c93eebbf452db91d41c5fe1196fe04abe 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -1602,4 +1602,11 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
public boolean isVrShellEnabled() {
return mVrShellDelegate.isVrShellEnabled();
}
+
+ // TODO(mthiesse): Toggle toolbar overlay, popups, etc.
+ public void setUIVisibilityForVR(int visibility) {
+ mControlContainer.setVisibility(visibility);
Ted C 2016/09/12 23:33:11 can your surfaceview sit on top? do you need to h
mthiesse 2016/09/13 14:53:48 So I've duplicated what ContentVideoView does and
qinmin 2016/09/14 18:45:24 CompositorView calls setZOrderMediaOverlay(), so i
+ getCompositorViewHolder().getSurfaceView().setVisibility(visibility);
+ getCompositorViewHolder().setVisibility(visibility);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698