chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java - Issue 2319863005: Implement new compositor and ContentViewCore reparenting for VR Shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2319863005: Implement new compositor and ContentViewCore reparenting for VR Shell. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

index 62ce11d43cf8e9ca78e552c86fe184a6348501f5..85abde84758d6d613ac3516858f6947c8312da18 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

@@ -1597,4 +1597,11 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode

public boolean isVrShellEnabled() {

return mVrShellDelegate.isVrShellEnabled();

}

+ // TODO(mthiesse): Toggle toolbar overlay, popups, etc.

+ public void setClankUIVisibilityForVR(int visibility) {

+ mControlContainer.setVisibility(visibility);

+ getCompositorViewHolder().getSurfaceView().setVisibility(visibility);

+ getCompositorViewHolder().setVisibility(visibility);

+ }

}