Issue 2319863002: Revert "dart2js: Pass type information to constructor rather than add later."

Issue 2319863002: Revert "dart2js: Pass type information to constructor rather than add later." (Closed)

Created:
4 years, 3 months ago by sra1

Modified:
4 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "dart2js: Pass type information to constructor rather than add later." lib/mirrors/fields_type_test fails due to the extra fieldspec. We will have to filter or use some other technique to make constructor generation add the extra parameter and assignment. TBR=sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/cdd6eeb57dbb2d0715c6b93451ce5861c03afa49

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -145 lines)			Patch
M	pkg/compiler/lib/src/js_backend/backend.dart	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/constant_emitter.dart	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/class_stub_generator.dart	View	2 chunks	+3 lines, -12 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/model.dart	View	4 chunks	+2 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart	View	1 chunk	+5 lines, -15 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	2 chunks	+24 lines, -26 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/codegen.dart	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/ssa/nodes.dart	View	3 chunks	+5 lines, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/optimize.dart	View	7 chunks	+32 lines, -43 lines	0 comments	Download

Total messages: 2 (1 generated)

sra1

4 years, 3 months ago (2016-09-07 20:46:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cdd6eeb57dbb2d0715c6b93451ce5861c03afa49 (presubmit successful).