Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Side by Side Diff: scripts/slave/recipes/flutter/engine.py

Issue 2319853002: Remove ignored bot_update "force" parameter. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import contextlib 5 import contextlib
6 6
7 DEPS = [ 7 DEPS = [
8 'depot_tools/bot_update', 8 'depot_tools/bot_update',
9 'depot_tools/gclient', 9 'depot_tools/gclient',
10 'file', 10 'file',
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 src_cfg = api.gclient.make_config() 260 src_cfg = api.gclient.make_config()
261 soln = src_cfg.solutions.add() 261 soln = src_cfg.solutions.add()
262 soln.name = 'src/flutter' 262 soln.name = 'src/flutter'
263 soln.url = \ 263 soln.url = \
264 'https://chromium.googlesource.com/external/github.com/flutter/engine' 264 'https://chromium.googlesource.com/external/github.com/flutter/engine'
265 # TODO(eseidel): What does parent_got_revision_mapping do? Do I care? 265 # TODO(eseidel): What does parent_got_revision_mapping do? Do I care?
266 src_cfg.parent_got_revision_mapping['parent_got_revision'] = 'got_revision' 266 src_cfg.parent_got_revision_mapping['parent_got_revision'] = 'got_revision'
267 src_cfg.target_os = set(['android']) 267 src_cfg.target_os = set(['android'])
268 api.gclient.c = src_cfg 268 api.gclient.c = src_cfg
269 api.gclient.c.got_revision_mapping['src/flutter'] = 'got_engine_revision' 269 api.gclient.c.got_revision_mapping['src/flutter'] = 'got_engine_revision'
270 # TODO(eseidel): According to iannucci force=True is required. 270 api.bot_update.ensure_checkout()
271 # See https://codereview.chromium.org/1690713003#msg6
272 api.bot_update.ensure_checkout(force=True)
273 api.gclient.runhooks() 271 api.gclient.runhooks()
274 272
275 273
276 def RunSteps(api): 274 def RunSteps(api):
277 # buildbot sets 'clobber' to the empty string which is falsey, check with 'in' 275 # buildbot sets 'clobber' to the empty string which is falsey, check with 'in'
278 if 'clobber' in api.properties: 276 if 'clobber' in api.properties:
279 api.file.rmcontents('everything', api.path['slave_build']) 277 api.file.rmcontents('everything', api.path['slave_build'])
280 278
281 GetCheckout(api) 279 GetCheckout(api)
282 280
(...skipping 19 matching lines...) Expand all
302 BuildIOS(api) 300 BuildIOS(api)
303 301
304 302
305 def GenTests(api): 303 def GenTests(api):
306 # A valid commit to flutter/engine, to make the gsutil urls look real. 304 # A valid commit to flutter/engine, to make the gsutil urls look real.
307 for platform in ('mac', 'linux'): 305 for platform in ('mac', 'linux'):
308 yield (api.test(platform) + api.platform(platform, 64) 306 yield (api.test(platform) + api.platform(platform, 64)
309 + api.properties(mastername='client.flutter', 307 + api.properties(mastername='client.flutter',
310 buildername='%s Engine' % platform.capitalize(), 308 buildername='%s Engine' % platform.capitalize(),
311 slavename='fake-m1', clobber='')) 309 slavename='fake-m1', clobber=''))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698