Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: scripts/slave/recipes/devtools.py

Issue 2319853002: Remove ignored bot_update "force" parameter. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.types import freeze 5 from recipe_engine.types import freeze
6 6
7 DEPS = [ 7 DEPS = [
8 'chromium_checkout', 8 'chromium_checkout',
9 'depot_tools/bot_update', 9 'depot_tools/bot_update',
10 'depot_tools/gclient', 10 'depot_tools/gclient',
(...skipping 20 matching lines...) Expand all
31 31
32 def should_skip_checks(api): 32 def should_skip_checks(api):
33 if not api.tryserver.is_tryserver: 33 if not api.tryserver.is_tryserver:
34 return False 34 return False
35 return all( 35 return all(
36 not filename.startswith(AFFECTED_PATHS) 36 not filename.startswith(AFFECTED_PATHS)
37 for filename in api.chromium_checkout.get_files_affected_by_patch()) 37 for filename in api.chromium_checkout.get_files_affected_by_patch())
38 38
39 def RunSteps(api): 39 def RunSteps(api):
40 api.gclient.set_config('chromium') 40 api.gclient.set_config('chromium')
41 api.bot_update.ensure_checkout(force=True) 41 api.bot_update.ensure_checkout()
42 42
43 if should_skip_checks(api): 43 if should_skip_checks(api):
44 api.step('skip checks', ['echo', 'no devtools file in patch']) 44 api.step('skip checks', ['echo', 'no devtools file in patch'])
45 return 45 return
46 46
47 def get_devtools_path(*sub_paths): 47 def get_devtools_path(*sub_paths):
48 devtools_sub_path = ('third_party', 'WebKit', 'Source', 'devtools') 48 devtools_sub_path = ('third_party', 'WebKit', 'Source', 'devtools')
49 joined_path = devtools_sub_path + sub_paths 49 joined_path = devtools_sub_path + sub_paths
50 return api.path['checkout'].join(*joined_path) 50 return api.path['checkout'].join(*joined_path)
51 51
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 ) 94 )
95 yield ( 95 yield (
96 api.test(config['testname'] + '_tryserver_with_devtools') + 96 api.test(config['testname'] + '_tryserver_with_devtools') +
97 tryserver_properties(api, mastername, config) + 97 tryserver_properties(api, mastername, config) +
98 api.override_step_data( 98 api.override_step_data(
99 'git diff to analyze patch', 99 'git diff to analyze patch',
100 api.raw_io.stream_output( 100 api.raw_io.stream_output(
101 'third_party/WebKit/Source/devtools/fake.js\n') 101 'third_party/WebKit/Source/devtools/fake.js\n')
102 ) 102 )
103 ) 103 )
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698