Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: scripts/slave/recipes/dart/dart.py

Issue 2319853002: Remove ignored bot_update "force" parameter. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.recipe_api import Property 5 from recipe_engine.recipe_api import Property
6 6
7 DEPS = [ 7 DEPS = [
8 'depot_tools/bot_update', 8 'depot_tools/bot_update',
9 'depot_tools/gclient', 9 'depot_tools/gclient',
10 'file', 10 'file',
11 'recipe_engine/path', 11 'recipe_engine/path',
12 'recipe_engine/platform', 12 'recipe_engine/platform',
13 'recipe_engine/properties', 13 'recipe_engine/properties',
14 'recipe_engine/python', 14 'recipe_engine/python',
15 'recipe_engine/step', 15 'recipe_engine/step',
16 'test_utils', 16 'test_utils',
17 ] 17 ]
18 18
19 def RunSteps(api): 19 def RunSteps(api):
20 buildername = str(api.properties.get('buildername')) # Convert from unicode. 20 buildername = str(api.properties.get('buildername')) # Convert from unicode.
21 21
22 api.gclient.set_config('dart') 22 api.gclient.set_config('dart')
23 23
24 if 'vm-precomp-android' in buildername: 24 if 'vm-precomp-android' in buildername:
25 api.gclient.apply_config('android') 25 api.gclient.apply_config('android')
26 26
27 api.bot_update.ensure_checkout(force=True) 27 api.bot_update.ensure_checkout()
28 api.gclient.runhooks() 28 api.gclient.runhooks()
29 29
30 extra_build_args = api.properties.get('build_args', []) 30 extra_build_args = api.properties.get('build_args', [])
31 mode = api.properties.get('mode', 'release') 31 mode = api.properties.get('mode', 'release')
32 target_arch = api.properties.get('target_arch', 'x64') 32 target_arch = api.properties.get('target_arch', 'x64')
33 build_targets = api.properties.get('build_targets', ['runtime', 'create_sdk']) 33 build_targets = api.properties.get('build_targets', ['runtime', 'create_sdk'])
34 build_args = ['-m%s' % mode, '--arch=%s' % target_arch] 34 build_args = ['-m%s' % mode, '--arch=%s' % target_arch]
35 build_args.extend(extra_build_args) 35 build_args.extend(extra_build_args)
36 build_args.extend(build_targets) 36 build_args.extend(build_targets)
37 api.python('build dart', 37 api.python('build dart',
(...skipping 27 matching lines...) Expand all
65 api.properties.generic(mastername='client.dart.FYI', 65 api.properties.generic(mastername='client.dart.FYI',
66 buildername='vm-precomp-android-release', 66 buildername='vm-precomp-android-release',
67 target_arch='arm', 67 target_arch='arm',
68 build_args=['--os=android'], 68 build_args=['--os=android'],
69 build_targets=['runtime_precompiled'], 69 build_targets=['runtime_precompiled'],
70 test_args=[ 70 test_args=[
71 '-cprecompiler', 71 '-cprecompiler',
72 '-rdart_precompiled', 72 '-rdart_precompiled',
73 '--exclude-suite=pkg', 73 '--exclude-suite=pkg',
74 '--system=android'])) 74 '--system=android']))
OLDNEW
« no previous file with comments | « scripts/slave/recipes/custom_tabs_client.expected/basic.json ('k') | scripts/slave/recipes/dart/dart.expected/linux64.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698