Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: scripts/slave/recipe_modules/syzygy/api.py

Issue 2319853002: Remove ignored bot_update "force" parameter. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import ast 5 import ast
6 import os 6 import os
7 import re 7 import re
8 8
9 from recipe_engine import recipe_api 9 from recipe_engine import recipe_api
10 10
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 154
155 This invokes a dummy step on the test slave as killing all instances of 155 This invokes a dummy step on the test slave as killing all instances of
156 Chrome seriously impairs development. 156 Chrome seriously impairs development.
157 """ 157 """
158 if self.m.properties['slavename'] == 'fake_slave': 158 if self.m.properties['slavename'] == 'fake_slave':
159 return self.m.python.inline('taskkill', 'print "dummy taskkill"') 159 return self.m.python.inline('taskkill', 'print "dummy taskkill"')
160 return self.m.chromium.taskkill() 160 return self.m.chromium.taskkill()
161 161
162 def checkout(self): 162 def checkout(self):
163 """Checks out the Syzygy code using the current gclient configuration.""" 163 """Checks out the Syzygy code using the current gclient configuration."""
164 step = self.m.bot_update.ensure_checkout(force=True) 164 step = self.m.bot_update.ensure_checkout()
165 self._revision = step.presentation.properties['got_revision'] 165 self._revision = step.presentation.properties['got_revision']
166 github_url = self._SYZYGY_GITHUB + str(self._revision) 166 github_url = self._SYZYGY_GITHUB + str(self._revision)
167 step.presentation.links[str(self._revision)] = github_url 167 step.presentation.links[str(self._revision)] = github_url
168 return step 168 return step
169 169
170 def runhooks(self): 170 def runhooks(self):
171 return self.m.chromium.runhooks() 171 return self.m.chromium.runhooks()
172 172
173 def compile(self): 173 def compile(self):
174 """Generates a step to compile the project.""" 174 """Generates a step to compile the project."""
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 '--overwrite', 322 '--overwrite',
323 '--verbose'] 323 '--verbose']
324 return self.m.python('download_binaries', get_syzygy_binaries_py, args) 324 return self.m.python('download_binaries', get_syzygy_binaries_py, args)
325 325
326 def smoke_test(self): 326 def smoke_test(self):
327 """Returns a step that launches the smoke test script.""" 327 """Returns a step that launches the smoke test script."""
328 smoke_test_py = self.internal_scripts_dir.join('smoke_test.py') 328 smoke_test_py = self.internal_scripts_dir.join('smoke_test.py')
329 build_dir = self.m.path['checkout'].join('build') 329 build_dir = self.m.path['checkout'].join('build')
330 args = ['--verbose', '--build-dir', build_dir] 330 args = ['--verbose', '--build-dir', build_dir]
331 return self.m.python('smoke_test', smoke_test_py, args) 331 return self.m.python('smoke_test', smoke_test_py, args)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698