Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: scripts/slave/recipe_modules/pgo/api.py

Issue 2319853002: Remove ignored bot_update "force" parameter. (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine import recipe_api 5 from recipe_engine import recipe_api
6 6
7 7
8 # List of the benchmark that we run during the profiling step. 8 # List of the benchmark that we run during the profiling step.
9 # 9 #
10 # TODO(sebmarchand): Move this into a BenchmarkSuite in telemetry, this way 10 # TODO(sebmarchand): Move this into a BenchmarkSuite in telemetry, this way
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 it and then compiling the optimized version of it. 104 it and then compiling the optimized version of it.
105 """ 105 """
106 self.m.gclient.set_config(bot_config['gclient_config']) 106 self.m.gclient.set_config(bot_config['gclient_config'])
107 107
108 # Augment the solution if needed. 108 # Augment the solution if needed.
109 self.m.gclient.c.solutions[0].url += bot_config.get('url_suffix', '') 109 self.m.gclient.c.solutions[0].url += bot_config.get('url_suffix', '')
110 110
111 if self.m.properties.get('slavename') != 'fake_slave': 111 if self.m.properties.get('slavename') != 'fake_slave':
112 self.m.chromium.taskkill() 112 self.m.chromium.taskkill()
113 113
114 self.m.bot_update.ensure_checkout(force=True) 114 self.m.bot_update.ensure_checkout()
115 if bot_config.get('patch_root'): 115 if bot_config.get('patch_root'):
116 self.m.path['checkout'] = self.m.path['slave_build'].join( 116 self.m.path['checkout'] = self.m.path['slave_build'].join(
117 bot_config.get('patch_root')) 117 bot_config.get('patch_root'))
118 118
119 # First step: compilation of the instrumented build. 119 # First step: compilation of the instrumented build.
120 self._compile_instrumented_image(bot_config) 120 self._compile_instrumented_image(bot_config)
121 121
122 # Second step: profiling of the instrumented build. 122 # Second step: profiling of the instrumented build.
123 self._run_pgo_benchmarks() 123 self._run_pgo_benchmarks()
124 124
125 # Third step: Compilation of the optimized build, this will use the 125 # Third step: Compilation of the optimized build, this will use the
126 # profile data files produced by the previous step. 126 # profile data files produced by the previous step.
127 self._compile_optimized_image(bot_config) 127 self._compile_optimized_image(bot_config)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698