Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2319843003: Fix strange failures on Android N (Closed)

Created:
4 years, 3 months ago by kjlubick
Modified:
4 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix strange failures on Android N We were seeing problems where dm ended with exit code 0, but the step still failed. It seems they changed what N returns when a thing completes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319843003 TBR=bugsbunny Committed: https://skia.googlesource.com/skia/+/b4403ee980dcc05fbefba7e587884032e893f8f8

Patch Set 1 #

Patch Set 2 : Double brackets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M infra/bots/recipe_modules/flavor/android_flavor.py View 1 chunk +1 line, -1 line 0 comments Download
M platform_tools/android/bin/android_run_skia View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319843003/20001
4 years, 3 months ago (2016-09-08 19:34:37 UTC) #5
kjlubick
4 years, 3 months ago (2016-09-08 19:35:06 UTC) #6
borenet
LGTM
4 years, 3 months ago (2016-09-08 19:36:14 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 20:04:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b4403ee980dcc05fbefba7e587884032e893f8f8

Powered by Google App Engine
This is Rietveld 408576698