Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2319843002: Fix null check to avoid RendererDidNavigateSamePage crash. (Closed)

Created:
4 years, 3 months ago by Charlie Reis
Modified:
4 years, 3 months ago
Reviewers:
nasko
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix null check to avoid RendererDidNavigateSamePage crash. We shouldn't treat a navigation as NAVIGATION_TYPE_SAME_PAGE if there is no last committed entry. BUG=640429 TEST=No known repro steps. Crashes should go away. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/08557a213c024dbc17f0f8e62aa31e8bae212711 Cr-Commit-Position: refs/heads/master@{#417070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Charlie Reis
Nasko, can you review this correction to https://codereview.chromium.org/2273613003/? Thanks for pointing the crashes out to ...
4 years, 3 months ago (2016-09-07 20:18:05 UTC) #5
nasko
LGTM
4 years, 3 months ago (2016-09-07 20:19:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319843002/1
4 years, 3 months ago (2016-09-07 20:30:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 22:00:29 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:02:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08557a213c024dbc17f0f8e62aa31e8bae212711
Cr-Commit-Position: refs/heads/master@{#417070}

Powered by Google App Engine
This is Rietveld 408576698