Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2319823002: DevTools: Fix eslint errors (Closed)

Created:
4 years, 3 months ago by chenwilliam
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix eslint errors Found these eslint errors on the new devtools buildbot I setup! Right now, the buildbot is configured to be non-blocking (i.e. the errors don't prevent commits from landing), but eventually it will be. Eslint errors from buildbot: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_DevTools_Linux%2F475%2F%2B%2Frecipes%2Fsteps%2Frun_eslint%2F0%2Fstdout BUG=none Committed: https://crrev.com/8aacb7fc357ade50fe72bbd6149bd8c14b2a23c6 Cr-Commit-Position: refs/heads/master@{#417125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystem.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chenwilliam
PTAL.
4 years, 3 months ago (2016-09-07 19:31:58 UTC) #2
dgozman
lgtm This is great!
4 years, 3 months ago (2016-09-07 22:09:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319823002/1
4 years, 3 months ago (2016-09-07 22:14:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 00:04:05 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 00:07:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8aacb7fc357ade50fe72bbd6149bd8c14b2a23c6
Cr-Commit-Position: refs/heads/master@{#417125}

Powered by Google App Engine
This is Rietveld 408576698