Fix Crankshafted CompareNil of constant values

src/hydrogen.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1730 matching lines @@
 }
 
 
 void HGraphBuilder::BuildCompareNil(
     HValue* value,
     Handle<Type> type,
     int position,
     HIfContinuation* continuation) {
   IfBuilder if_nil(this, position);
   bool needs_or = false;
-  if (type->Maybe(Type::Null())) {
-    if (needs_or) if_nil.Or();
-    if_nil.If<HCompareObjectEqAndBranch>(value, graph()->GetConstantNull());
-    needs_or = true;
-  }
-  if (type->Maybe(Type::Undefined())) {
-    if (needs_or) if_nil.Or();
-    if_nil.If<HCompareObjectEqAndBranch>(value,
-                                         graph()->GetConstantUndefined());
-    needs_or = true;
-  }
-  if (type->Maybe(Type::Undetectable())) {
-    if (needs_or) if_nil.Or();
-    if_nil.If<HIsUndetectableAndBranch>(value);
+  if (value->IsConstant()) {
+    bool is_null = false;
+    HConstant* constant_value = HConstant::cast(value);
+    if (!constant_value->HasNumberValue()) {
+      Object* constant_object = *(constant_value->handle());

[Jakob Kummerow, 2013/08/14 15:45:20]

nit: let's just keep this handlified, i.e.:
Handle<Object> constant_object = constant_value->handle();

+      is_null = constant_object->IsNull() ||
+          constant_object->IsUndefined() ||
+          constant_object->IsUndetectableObject();
+    }
+    constant_value = is_null
+        ? graph()->GetConstantTrue()
+        : graph()->GetConstantFalse();
+    if_nil.If<HCompareObjectEqAndBranch>(constant_value,
+                                         graph()->GetConstantTrue());
   } else {
-    if_nil.Then();
-    if_nil.Else();
-    if (type->NumClasses() == 1) {
-      BuildCheckHeapObject(value);
-      // For ICs, the map checked below is a sentinel map that gets replaced by
-      // the monomorphic map when the code is used as a template to generate a
-      // new IC. For optimized functions, there is no sentinel map, the map
-      // emitted below is the actual monomorphic map.
-      BuildCheckMap(value, type->Classes().Current());
+    if (type->Maybe(Type::Null())) {
+      if (needs_or) if_nil.Or();
+      if_nil.If<HCompareObjectEqAndBranch>(value, graph()->GetConstantNull());
+      needs_or = true;
+    }
+    if (type->Maybe(Type::Undefined())) {
+      if (needs_or) if_nil.Or();
+      if_nil.If<HCompareObjectEqAndBranch>(value,
+                                           graph()->GetConstantUndefined());
+      needs_or = true;
+    }
+    if (type->Maybe(Type::Undetectable())) {
+      if (needs_or) if_nil.Or();
+      if_nil.If<HIsUndetectableAndBranch>(value);
     } else {
-      if_nil.Deopt("Too many undetectable types");
+      if_nil.Then();
+      if_nil.Else();
+      if (type->NumClasses() == 1) {
+        BuildCheckHeapObject(value);
+        // For ICs, the map checked below is a sentinel map that gets replaced
+        // by the monomorphic map when the code is used as a template to
+        // generate a new IC. For optimized functions, there is no sentinel map,
+        // the map emitted below is the actual monomorphic map.
+        BuildCheckMap(value, type->Classes().Current());
+      } else {
+        if_nil.Deopt("Too many undetectable types");
+      }
     }
   }
 
   if_nil.CaptureContinuation(continuation);
 }
 
 
 HValue* HGraphBuilder::BuildCreateAllocationMemento(HValue* previous_object,
                                                     int previous_object_size,
                                                     HValue* alloc_site) {
@@ skipping 8056 matching lines @@
   if (ShouldProduceTraceOutput()) {
     isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
   }
 
 #ifdef DEBUG
   graph_->Verify(false);  // No full verify.
 #endif
 }
 
 } }  // namespace v8::internal