Issue 23198002: Fix Crankshafted CompareNil of constant values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23198002: Fix Crankshafted CompareNil of constant values (Closed)

Created:
7 years, 4 months ago by danno

Modified:
7 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix Crankshafted CompareNil of constant values R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16193

Patch Set 3 : Fix both uses of handle_ #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	src/hydrogen-instructions.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
	A +	test/mjsunit/constant-compare-nil-value.js	View		1 chunk	+9 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nit. https://codereview.chromium.org/23198002/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/23198002/diff/1/src/hydrogen.cc#newcode1755 src/hydrogen.cc:1755: Object* constant_object = *(constant_value->handle()); nit: let's ...

7 years, 4 months ago (2013-08-14 15:45:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r16193.

Expand Messages | Collapse Messages

Issue 23198002: Fix Crankshafted CompareNil of constant values (Closed)

Description

Patch Set 1 #

Patch Set 2 : Simpler fix #

Patch Set 3 : Fix both uses of handle_ #

Messages