Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chromeos/dbus/dbus_client_bundle_unittest.cc

Issue 2319783002: mash: Allow a subset of D-Bus clients to be created in DBusThreadManager (Closed)
Patch Set: WIP, add DBusThreadManagerAsh and DBusThreadManagerChrome Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/dbus_client_bundle.cc ('k') | chromeos/dbus/dbus_client_implementation_type.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/dbus_client_bundle_unittest.cc
diff --git a/chromeos/dbus/dbus_client_bundle_unittest.cc b/chromeos/dbus/dbus_client_bundle_unittest.cc
index bfc439b59504e481d359e73b253134942724a139..6cddc134507c7e3fda2f57d9b7e9906261b7b979 100644
--- a/chromeos/dbus/dbus_client_bundle_unittest.cc
+++ b/chromeos/dbus/dbus_client_bundle_unittest.cc
@@ -4,11 +4,42 @@
#include "chromeos/dbus/dbus_client_bundle.h"
-#include "base/compiler_specific.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace chromeos {
+// Tests that real and fake clients can be created and that some clients can be
+// skipped.
+TEST(DBusClientBundleTest, CreateClientBundle) {
+ const DBusClientTypeMask real_clients =
+ DBusClientBundle::CRAS | DBusClientBundle::CROS_DISKS;
+ const DBusClientTypeMask fake_clients =
+ DBusClientBundle::PERMISSION_BROKER | DBusClientBundle::POWER_MANAGER;
+ DBusClientBundle bundle(real_clients, fake_clients);
+ EXPECT_TRUE(bundle.IsUsingAnyRealClient());
+
+ // Real clients are real.
+ EXPECT_TRUE(bundle.cras_audio_client());
+ EXPECT_TRUE(bundle.cros_disks_client());
+ EXPECT_TRUE(bundle.IsUsingReal(DBusClientBundle::CRAS));
+ EXPECT_TRUE(bundle.IsUsingReal(DBusClientBundle::CROS_DISKS));
+ EXPECT_FALSE(bundle.IsUsingFake(DBusClientBundle::CRAS));
+ EXPECT_FALSE(bundle.IsUsingFake(DBusClientBundle::CROS_DISKS));
+
+ // Fake clients are fake.
+ EXPECT_TRUE(bundle.permission_broker_client());
+ EXPECT_TRUE(bundle.power_manager_client());
+ EXPECT_TRUE(bundle.IsUsingFake(DBusClientBundle::PERMISSION_BROKER));
+ EXPECT_TRUE(bundle.IsUsingFake(DBusClientBundle::POWER_MANAGER));
+ EXPECT_FALSE(bundle.IsUsingReal(DBusClientBundle::PERMISSION_BROKER));
+ EXPECT_FALSE(bundle.IsUsingReal(DBusClientBundle::POWER_MANAGER));
+
+ // Uninitialized clients don't exist.
+ EXPECT_FALSE(bundle.update_engine_client());
+ EXPECT_FALSE(bundle.IsUsingReal(DBusClientBundle::UPDATE_ENGINE));
+ EXPECT_FALSE(bundle.IsUsingFake(DBusClientBundle::UPDATE_ENGINE));
+}
+
TEST(DBusClientBundleTest, UnstubFlagParser) {
EXPECT_EQ(0, DBusClientBundle::ParseUnstubList("foo"));
« no previous file with comments | « chromeos/dbus/dbus_client_bundle.cc ('k') | chromeos/dbus/dbus_client_implementation_type.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698